From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36610: [PATCH] Make finder-exit use quit-window Date: Fri, 12 Jul 2019 09:34:28 +0300 Message-ID: <83y3133gnf.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="97297"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36610@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 12 08:35:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlp99-000Acm-7n for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 08:35:07 +0200 Original-Received: from localhost ([::1]:46922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlp97-0000jK-RX for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 02:35:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51235) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlp95-0000jC-7l for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 02:35:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlp94-0004Ub-Bq for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 02:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58576) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlp94-0004TG-6O for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 02:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlp93-0002ld-Uz for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 02:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jul 2019 06:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36610 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36610-submit@debbugs.gnu.org id=B36610.156291328510611 (code B ref 36610); Fri, 12 Jul 2019 06:35:01 +0000 Original-Received: (at 36610) by debbugs.gnu.org; 12 Jul 2019 06:34:45 +0000 Original-Received: from localhost ([127.0.0.1]:39164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlp8n-0002l4-4d for submit@debbugs.gnu.org; Fri, 12 Jul 2019 02:34:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlp8l-0002kr-61 for 36610@debbugs.gnu.org; Fri, 12 Jul 2019 02:34:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hlp8f-0004Cd-T5; Fri, 12 Jul 2019 02:34:37 -0400 Original-Received: from [176.228.60.248] (port=2667 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hlp8f-0003eM-E7; Fri, 12 Jul 2019 02:34:37 -0400 In-reply-to: (message from Stefan Kangas on Fri, 12 Jul 2019 00:57:26 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173302 > From: Stefan Kangas > Date: Fri, 12 Jul 2019 00:57:26 +0200 > > Stefan Kangas writes: > > > When I have two windows open and hit C-h p to open finder, then press q to exit, > > the second window is suddenly gone. This is because finder-exit uses > > kill-window instead of quit-window, and is a minor annoyance. > > That should of course be "delete-window instead of quit-window". Yes, but please also explain the motivation for the change. In particular, what do you mean by "gone" in the above description? Doesn't quit-window also make the window go away, and since you call it with 2nd arg non-nil, also kill the buffer? So I'm unsure I understand the essence of the change and more importantly its user-visible effects. Thanks.