From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 21:46:54 +0300 Message-ID: <83y2xkcyu9.fsf@gnu.org> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="191483"; mail-complaints-to="usenet@blaine.gmane.org" Cc: andreyorst@gmail.com, spacibba@aol.com, 37774@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 20:48:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKoLD-000ngh-LU for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 20:48:11 +0200 Original-Received: from localhost ([::1]:47056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKoLC-0003Dv-5o for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 14:48:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56546) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKoL5-0003CM-B4 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:48:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKoL4-0007Nj-6P for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37711) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKoL4-0007Ne-34 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKoL3-0008FJ-S5 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 18:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157125164031651 (code B ref 37774); Wed, 16 Oct 2019 18:48:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 18:47:20 +0000 Original-Received: from localhost ([127.0.0.1]:46532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKoKO-0008EQ-6V for submit@debbugs.gnu.org; Wed, 16 Oct 2019 14:47:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKoKM-0008EC-Pq for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 14:47:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKoKH-0006xj-7n; Wed, 16 Oct 2019 14:47:13 -0400 Original-Received: from [176.228.60.248] (port=4029 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKoKG-0004wc-LP; Wed, 16 Oct 2019 14:47:13 -0400 In-reply-to: <87k194fvn7.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 16 Oct 2019 20:27:40 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169477 Archived-At: > From: Juri Linkov > Cc: Eli Zaretskii , Andrey Orst , > 37774@debbugs.gnu.org > Date: Wed, 16 Oct 2019 20:27:40 +0300 > > 1. Backward-compatibility problem: > > I had to spend significant time investigating why the region face broke > recently, and discovered that customized faces in custom-set-faces need > to be updated. I'm not sure I understand: the region face is defined to be extended beyond EOL. How does custom-set-faces enter this picture, and why did you need to do anything about the customized faces? > Soon I tired fixing their customizations one by one manually, Which other faces needed to be "fixed", how, and why? > All faces could be divided into two more-less equally large groups: > > a. faces with distinct foreground that highlight text properties, > they include mostly font-lock faces, underline faces, and so on; > > b. faces with distinct background that highlight blocks of text, > such as the region face, diff hunk faces, etc. Why are you talking only about the colors? face extension is not only about colors, it's about other attributes as well: underline, strike-through, box, etc. You list underline with foreground color, but they are not the same as color, especially not when face extension is concerned. They actually behave more like background colors. And then there are faces with both foreground and background colors. > As I see the change was meant to fix only the problem that relates to > faces with distinct foreground, because indeed underlines extended > to the window edge look very ugly. So the change should affect > only faces with distinct foreground. That wasn't the intent. the intent was explicitly to cause the change in background color and underline/strikethough/etc. attributes--those which show in the face extension. Foreground color doesn't show in face extension. > This screenshot demonstrates how badly broken these blocks are now > in diff-mode that it makes harder to read diffs: I'm sorry, but I don't see why it is broken or hard to read. > Ideally to be more nice-looking, background colors in such faces should be > extended to the column defined e.g. by display-fill-column-indicator-column. That would be ugly if the line's text extends beyond the fill-column, no? Also, it would look even uglier with variable-pitch fonts.