From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Sun, 20 Oct 2019 09:03:03 +0300 Message-ID: <83y2xg54yw.fsf@gnu.org> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <871rvceeqp.fsf@mail.linkov.net> <83tv88cyic.fsf@gnu.org> <83pniwcvon.fsf@gnu.org> <87pniw30td.fsf@mail.linkov.net> <4dc05091-53db-bff9-4623-0aedd9c2907f@gmx.at> <87h8476mhz.fsf@mail.linkov.net> <83wod28ryn.fsf@gnu.org> <87v9sko6k4.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="39062"; mail-complaints-to="usenet@blaine.gmane.org" Cc: andreyorst@gmail.com, 37774@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 20 08:04:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iM4K3-000A24-Me for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 08:04:11 +0200 Original-Received: from localhost ([::1]:51260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iM4K2-0006MO-3t for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 02:04:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48075) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iM4Jv-0006M3-Lk for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 02:04:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iM4Ju-0000DK-K6 for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 02:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44870) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iM4Ju-0000DF-HC for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 02:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iM4Ju-0008SM-A3 for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 02:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2019 06:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157155140032456 (code B ref 37774); Sun, 20 Oct 2019 06:04:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 20 Oct 2019 06:03:20 +0000 Original-Received: from localhost ([127.0.0.1]:53691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iM4JE-0008RP-CJ for submit@debbugs.gnu.org; Sun, 20 Oct 2019 02:03:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iM4JD-0008RC-4N for 37774@debbugs.gnu.org; Sun, 20 Oct 2019 02:03:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iM4J7-0008Da-CW; Sun, 20 Oct 2019 02:03:13 -0400 Original-Received: from [176.228.60.248] (port=3994 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iM4J6-0002V7-SI; Sun, 20 Oct 2019 02:03:13 -0400 In-reply-to: <87v9sko6k4.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 19 Oct 2019 23:53:47 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169764 Archived-At: > From: Juri Linkov > Cc: rudalics@gmx.at, andreyorst@gmail.com, 37774@debbugs.gnu.org > Date: Sat, 19 Oct 2019 23:53:47 +0300 > > So I added :extend to diff faces, except word-based refinement faces. Thanks. > Also I considered adding :extend to multi-line isearch matches, > but in fact yanking in isearch is word-based such as C-w, > so maybe the current default is fine. Or do you think it's important > to extend highlighting of matched empty lines beyond EOL > to make them more noticeable? Then we'll need to extend > matching of empty like also for lazy-highlight, hi-lock, occur faces. I think we should add :extend only if there's little doubt about its necessity. So let's wait with the Isearch faces until we are sure. > Additional question: since now in multi-line Info references faces don't > extend beyond EOL by default, could the following hack to be removed > from info.el: > > ;; For multiline ref, unfontify newline and surrounding whitespace > (save-excursion > (goto-char rbeg) > (save-match-data > (while (re-search-forward "\\s-*\n\\s-*" rend t nil) > (remove-text-properties (match-beginning 0) > (match-end 0) > '(font-lock-face t))))) Yes, I think so, but maybe leave this code in place conditioned by the relevant face being extended, in case users customize them?