From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap) Date: Sun, 20 Oct 2019 19:07:11 +0300 Message-ID: <83y2xf4d00.fsf@gnu.org> References: <83a7a2gxp0.fsf@gnu.org> <83a79v620e.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="37167"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37755@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 20 18:08:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMDkY-0009XK-UB for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 18:08:11 +0200 Original-Received: from localhost ([::1]:39798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMDkX-0005me-PY for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 12:08:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59629) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMDkR-0005mW-Qd for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 12:08:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMDkQ-0004Xq-Px for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 12:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46330) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMDkQ-0004Xl-Mr for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 12:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMDkQ-0006R0-GS for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 12:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2019 16:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37755-submit@debbugs.gnu.org id=B37755.157158764724685 (code B ref 37755); Sun, 20 Oct 2019 16:08:02 +0000 Original-Received: (at 37755) by debbugs.gnu.org; 20 Oct 2019 16:07:27 +0000 Original-Received: from localhost ([127.0.0.1]:55151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMDjr-0006Q5-0v for submit@debbugs.gnu.org; Sun, 20 Oct 2019 12:07:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMDjp-0006Pt-Bn for 37755@debbugs.gnu.org; Sun, 20 Oct 2019 12:07:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMDjk-0004O7-8n; Sun, 20 Oct 2019 12:07:20 -0400 Original-Received: from [176.228.60.248] (port=2096 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMDjj-0004Kw-Pg; Sun, 20 Oct 2019 12:07:20 -0400 In-reply-to: (message from Carlos Pita on Sun, 20 Oct 2019 12:47:13 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169831 Archived-At: > From: Carlos Pita > Date: Sun, 20 Oct 2019 12:47:13 -0300 > Cc: 37755@debbugs.gnu.org > > > What did I miss? > > The call to gui_init_fringe I guess. I don't see that call in the patch, nor any changes in gui_init_fringe that would modify its current effect. If you mean the existing calls, then they are only made at run time, which would mean Emacs is dumped without the standard bitmaps? Why is that? > Also, notice that define_fringe_bitmap is quite different than > Fdefine_fringe_bitmap. Sure, but I said define-fringe-bitmap, which is the Lisp name of Fdefine_fringe_bitmap. > I suggest you take a look at the modified pseudo code I posted quite a > few message above. I will, but I'd like to see the full patch as well. > Besides, whatever is missing after the C static initialization part is > just this *platform dependent* bit shuffling, which I seriously doubt > emacs could make sense of without the appropriate rif at hand, so > quite late in the initialization sequence. I even suggested to avoid > this destructive manipulation of platform independent bitmaps from the > part of the rifs, although I've only followed my suggestion in the > case of cairo, which was quite natural and convenient. If RIF is the problem, we could make each terminal backend do this initialization unconditionally at dump time.