From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11680: flyspell should use mouse-3 instead of mouse-2 Date: Thu, 16 Jan 2020 16:46:45 +0200 Message-ID: <83y2u731d6.fsf@gnu.org> References: <87imo3ihjk.fsf@skangas.se> <83ftj7l8jj.fsf@gnu.org> <83k18ik971.fsf@gnu.org> <87d0bkyxt0.fsf@marxist.se> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="35909"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 11680@debbugs.gnu.org, l26wang@gmail.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 16 15:47:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1is6QU-0009Fv-Ow for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jan 2020 15:47:14 +0100 Original-Received: from localhost ([::1]:43292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is6QT-0002Qa-KG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jan 2020 09:47:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54919) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is6QJ-0002O9-LJ for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2020 09:47:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1is6QI-0008Kf-Im for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2020 09:47:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59252) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1is6QI-0008KO-Fu for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2020 09:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1is6QI-0006Y5-Cd for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2020 09:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jan 2020 14:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11680 X-GNU-PR-Package: emacs Original-Received: via spool by 11680-submit@debbugs.gnu.org id=B11680.157918600524463 (code B ref 11680); Thu, 16 Jan 2020 14:47:02 +0000 Original-Received: (at 11680) by debbugs.gnu.org; 16 Jan 2020 14:46:45 +0000 Original-Received: from localhost ([127.0.0.1]:36992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1is6Px-0006Ju-EB for submit@debbugs.gnu.org; Thu, 16 Jan 2020 09:46:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1is6Ps-0006C2-3g for 11680@debbugs.gnu.org; Thu, 16 Jan 2020 09:46:39 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1is6Pm-0007hU-LY; Thu, 16 Jan 2020 09:46:30 -0500 Original-Received: from [176.228.60.248] (port=1748 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1is6Pm-0002jK-08; Thu, 16 Jan 2020 09:46:30 -0500 In-reply-to: <87d0bkyxt0.fsf@marxist.se> (message from Stefan Kangas on Thu, 16 Jan 2020 02:50:19 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174723 Archived-At: > From: Stefan Kangas > Cc: 11680@debbugs.gnu.org, l26wang@gmail.com > Date: Thu, 16 Jan 2020 02:50:19 +0100 > > > Fine with me, but that button is already bound to > > mouse-save-then-kill. I never use it, but what will those who do say? > > Since this key binding is only in flyspell-mouse-map, it will only be > rebound when the mouse pointer is over a misspelled word. Note that > mouse-2 is normally bound to mouse-yank-primary. I don't see how this resolves the backward-compatibility issue, sorry. > I therefore don't think it will be a big problem in practice. On the > contrary, I believe that having the context menu on the right mouse > button will feel more natural and be more discoverable to users. Once again, we are not talking about adding a new feature from scratch, we are talking about changing a very old behavior. So whether it's more natural or not is of secondary importance for this decision. I'm okay with making this conditional on some user option, but I object to an unconditional change. > I have attached an updated patch below. If there are no objections to > it, would this change be safe for the release branch, or should it go > to master? In any case, we don't add new features on the release branch, we only fix bugs there. Thanks.