From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39977: 28.0.50; Unhelpful stack trace Date: Sat, 28 Mar 2020 11:23:29 +0300 Message-ID: <83y2rk7uri.fsf@gnu.org> References: <83wo7o6nxs.fsf@gnu.org> <60dd4ced-a2e5-ed17-0570-b7bdd2a557af@gmx.at> <83blozckn2.fsf@gnu.org> <01305dbc-c69b-baf9-f0bf-1e5b8c04d970@gmx.at> <83y2s2bswl.fsf@gnu.org> <3ac189d0-5d05-fdf9-0922-0c464b1b17c3@gmx.at> <83k13lbgux.fsf@gnu.org> <83d09cb9gz.fsf@gnu.org> <69a74f9e-079b-a771-0213-f60ed0bf5720@gmx.at> <83y2rzf08m.fsf@gnu.org> <7a0b9999-6778-6235-fbc9-2a24b4e3bc53@gmx.at> <83tv2mg9j0.fsf@gnu.org> <9684641c-a59a-4ed6-a6b4-d3238f789050@gmx.at> <83sgi6g461.fsf@gnu.org> <90ac4084-4fbb-b5d7-6a7c-597d8f08e88a@gmx.at> <83imj1g1eu.fsf@gnu.org> <835zf1fobf.fsf@gnu.org> <4472dbf8-eec0-72eb-a4ad-c6b382d27f1f@gmx.at> <83zhcce7n2.fsf@gnu.org> <9a3df43d-4a83-bed0-9ad1-b59cf11b4c9c@gmx.at> <838sjtetmp.fsf@gnu.org> <88e06868-cfc2-7109-b5ea-71fea3aa897e@gmx.at> <83mu87b004.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="68576"; mail-complaints-to="usenet@ciao.gmane.io" Cc: enometh@meer.net, 39977@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 28 09:24:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jI6lG-000HkB-Rv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Mar 2020 09:24:10 +0100 Original-Received: from localhost ([::1]:51130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jI6lF-0005Ue-T1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Mar 2020 04:24:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56900) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jI6l9-0005UW-7W for bug-gnu-emacs@gnu.org; Sat, 28 Mar 2020 04:24:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jI6l8-0003IJ-5n for bug-gnu-emacs@gnu.org; Sat, 28 Mar 2020 04:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55894) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jI6l8-0003IF-2b for bug-gnu-emacs@gnu.org; Sat, 28 Mar 2020 04:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jI6l7-0007Yj-UZ for bug-gnu-emacs@gnu.org; Sat, 28 Mar 2020 04:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Mar 2020 08:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39977 X-GNU-PR-Package: emacs Original-Received: via spool by 39977-submit@debbugs.gnu.org id=B39977.158538381429013 (code B ref 39977); Sat, 28 Mar 2020 08:24:01 +0000 Original-Received: (at 39977) by debbugs.gnu.org; 28 Mar 2020 08:23:34 +0000 Original-Received: from localhost ([127.0.0.1]:33634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jI6kg-0007Xs-BO for submit@debbugs.gnu.org; Sat, 28 Mar 2020 04:23:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jI6ke-0007Xg-9y for 39977@debbugs.gnu.org; Sat, 28 Mar 2020 04:23:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jI6kY-0002rA-IW; Sat, 28 Mar 2020 04:23:26 -0400 Original-Received: from [176.228.60.248] (port=1175 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jI6kX-0001KO-Sj; Sat, 28 Mar 2020 04:23:26 -0400 In-Reply-To: (message from martin rudalics on Tue, 24 Mar 2020 10:45:16 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177800 Archived-At: > Cc: enometh@meer.net, 39977@debbugs.gnu.org > From: martin rudalics > Date: Tue, 24 Mar 2020 10:45:16 +0100 > > >> (and (frame-live-p (selected-frame)) > >> (window-live-p (selected-window)) > >> (eq (frame-selected-window (selected-frame)) > >> (selected-window))) > > > > I agree. But note that selected-frame could switch frames internally, > > if the last selected frame is dead; as long as selected-frame also > > adjusts the selected window, the above will still hold. > > Do you mean 'select-frame' instead of 'selected-frame'? No, I meant selected-frame. > > I'm okay with having non-deterministic behavior triggered by code that > > violates that invariant. We will tell people who write such Lisp code > > "if it hurts, don't do that". > > But till then we may have to handle reports of bugs that are very hard > to reproduce. Bugs that are caused by such invalid Lisp, and that manifest themselves by unexpected or unpredictable behavior, are fine with me. Of course, it would be good to find the causes of such bugs and point them out to the responsible Lisp programmer, but as long as we don't crash or lock up, we are in a relatively good shape. > >> Wrong type argument: window-live-p, # > >> > >> error in redisplay. > > > > That might not be the best solution, but it's "good enough" in my > > book. The programmer who writes such code deserves punishment, and an > > error in redisplay that doesn't lock up Emacs (or does it?) is ample > > punishment, IMO. > > This error might be due to the fact that _any_ of old_top_frame, > old_window and target_frame_window in unwind_format_mode_line can be > dead at the time of unwinding. unwind_format_mode_line is much to > fragile in this regard. Perhaps we should make unwind_format_mode_line less fragile, then. > And I have no idea yet why we need an extra unwind for restoring > selected_frame and selected_window. Shouldn't these go hand in hand > with what unwind_format_mode_line does? Does the one even know > about the other? I don't think I understand what extra unwind are you talking about here. Can you provide a more specific pointer to the relevant code?