From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30101: 25.3; defcustom does not clear old :options when reevaluated Date: Sat, 29 Aug 2020 18:41:24 +0300 Message-ID: <83y2lxxxwb.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26497"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 30101@debbugs.gnu.org, tim@tim-landscheidt.de To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 29 17:42:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kC2zi-0006ly-Aa for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Aug 2020 17:42:18 +0200 Original-Received: from localhost ([::1]:57582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kC2zh-0007zI-7T for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Aug 2020 11:42:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kC2zS-0007yZ-NU for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 11:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kC2zS-00088v-DH for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 11:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kC2zS-0002qi-AI for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 11:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Aug 2020 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30101 X-GNU-PR-Package: emacs Original-Received: via spool by 30101-submit@debbugs.gnu.org id=B30101.159871570110908 (code B ref 30101); Sat, 29 Aug 2020 15:42:02 +0000 Original-Received: (at 30101) by debbugs.gnu.org; 29 Aug 2020 15:41:41 +0000 Original-Received: from localhost ([127.0.0.1]:48892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC2z6-0002pr-R8 for submit@debbugs.gnu.org; Sat, 29 Aug 2020 11:41:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC2z5-0002pf-8V for 30101@debbugs.gnu.org; Sat, 29 Aug 2020 11:41:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54513) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kC2yz-00086Q-9N; Sat, 29 Aug 2020 11:41:33 -0400 Original-Received: from [176.228.60.248] (port=2989 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kC2yx-0001pZ-Lw; Sat, 29 Aug 2020 11:41:32 -0400 In-Reply-To: (message from Mauro Aranda on Sat, 29 Aug 2020 12:11:07 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186647 Archived-At: > From: Mauro Aranda > Date: Sat, 29 Aug 2020 12:11:07 -0300 > Cc: tim@tim-landscheidt.de, 30101@debbugs.gnu.org > > I took a shot at it. Please review. Thanks, I have a few comments. > * doc/lispref/customize.texi (Defining Customization Variables): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The name in parentheses should be the name of the node, not of the section. > +Re-evaluating a @code{defcustom} form of an already defined user > +option does not clear the reasonable values added by previous > +evaluations, or by calls to @code{custom-add-frequent-value}. This > +way, Lisp programs can add reasonable values for user options not yet > +defined. This doesn't emphasize the fact that you are talking about reevaluation after changing the option's values. Without that, this text doesn't drive the point home. Also, I'd suggest to drop the "reasonable" part, as it gets in the way of understanding the important parts by distracting the reader to think about what "reasonable" means in this context. > --- a/lisp/custom.el > +++ b/lisp/custom.el > @@ -578,9 +578,14 @@ custom-add-dependencies > (defun custom-add-option (symbol option) > "To the variable SYMBOL add OPTION. > > +Custom then presents OPTION to the user as a suggested member > +for the value of SYMBOL. > + > If SYMBOL's custom type is a hook, OPTION should be a hook member. > -If SYMBOL's custom type is an alist, OPTION specifies a symbol > -to offer to the user as a possible key in the alist. > +If SYMBOL's custom type is an alist, OPTION specifies a possible key > +in the alist. > +Similarly, if SYMBOL's custom type is a plist, OPTION specifies > +a possible name in the plist. > For other custom types, this has no effect." I don't think I understand what this tries to accomplish, or how it is relevant to the issue discussed here.