From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH] Date: Tue, 15 Sep 2020 17:30:31 +0300 Message-ID: <83y2lb8648.fsf@gnu.org> References: <20200915040728.77ufv7g6bekvrzqa@E15-2016.optimum.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23420"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43412@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 15 16:32:55 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIC0r-0005x5-NH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Sep 2020 16:32:53 +0200 Original-Received: from localhost ([::1]:50412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIC0q-0006Uh-Or for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Sep 2020 10:32:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIBz4-0005Gl-Cs for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 10:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48530) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIBz4-0002JR-3i for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 10:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIBz4-0005zP-1A for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 10:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Sep 2020 14:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43412-submit@debbugs.gnu.org id=B43412.160018024522998 (code B ref 43412); Tue, 15 Sep 2020 14:31:01 +0000 Original-Received: (at 43412) by debbugs.gnu.org; 15 Sep 2020 14:30:45 +0000 Original-Received: from localhost ([127.0.0.1]:60076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIByn-0005ys-4d for submit@debbugs.gnu.org; Tue, 15 Sep 2020 10:30:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIByl-0005yf-Ak for 43412@debbugs.gnu.org; Tue, 15 Sep 2020 10:30:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46078) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIByf-0002Bh-A6; Tue, 15 Sep 2020 10:30:37 -0400 Original-Received: from [176.228.60.248] (port=1228 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kIByV-0005Sg-Bj; Tue, 15 Sep 2020 10:30:35 -0400 In-Reply-To: <20200915040728.77ufv7g6bekvrzqa@E15-2016.optimum.net> (message from Boruch Baum on Tue, 15 Sep 2020 00:07:28 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188116 Archived-At: > Date: Tue, 15 Sep 2020 00:07:28 -0400 > From: Boruch Baum > > +(defcustom auto-revert-only-if-visible nil > + "If non-nil, suppress Auto-Revert Mode when a buffer isn't visible." "Visible" is ambiguous in this context. I suggest "not displayed in any window" instead. Or, better, just "auto-revert only if buffer is displayed" (which also solved a problem with double negation). > + :version "28") ^^^^ "28.1" > + (if (display-graphic-p) 'visible (window-normalize-frame nil))))))) Is the different treatment of GUI and TTY frames necessary here? Btw, what will be the effect of this option? Suppose some buffer was not displayed and missed its auto-revert opportunity. Then I switch to it in some window -- will it appear with stale contents, or will it auto-revert before being displayed in the window?