From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 45562@debbugs.gnu.org, stefan@marxist.se
Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm
Date: Fri, 01 Jan 2021 14:05:09 +0200 [thread overview]
Message-ID: <83y2hcg8wa.fsf@gnu.org> (raw)
In-Reply-To: <87h7o0c3sx.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 01 Jan 2021 12:08:46 +0100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Stefan Kangas <stefan@marxist.se>, 45562@debbugs.gnu.org
> Date: Fri, 01 Jan 2021 12:08:46 +0100
>
> >> --- a/src/alloc.c
> >> +++ b/src/alloc.c
> >> @@ -4001,7 +4001,7 @@ memory_full (size_t nbytes)
> >> {
> >> if (i == 0)
> >> free (spare_memory[i]);
> >> - else if (i >= 1 && i <= 4)
> >> + else if (i <= 4)
> >> lisp_align_free (spare_memory[i]);
> >> else
> >> lisp_free (spare_memory[i]);
> >
> > This is an optimization better left to the compiler, IMO.
>
> I think the change made the code slightly clearer, though? You don't
> have to think about whether there's anything in the range between 0 and
> >= 1.
If you like the modified code better, I won't object.
next prev parent reply other threads:[~2021-01-01 12:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 8:33 bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Stefan Kangas
2020-12-31 14:12 ` Eli Zaretskii
2021-01-01 11:08 ` Lars Ingebrigtsen
2021-01-01 11:37 ` Unknown
2021-01-01 16:10 ` Stefan Kangas
2021-01-01 12:05 ` Eli Zaretskii [this message]
2021-01-01 16:21 ` Stefan Kangas
2021-01-01 16:38 ` Andreas Schwab
2021-07-21 11:30 ` Lars Ingebrigtsen
2021-01-01 18:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y2hcg8wa.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=45562@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).