From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 02/15] Take offset not idx in PER_BUFFER_VALUE_P Date: Fri, 07 May 2021 15:54:25 +0300 Message-ID: <83y2cqbt6m.fsf@gnu.org> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-3-sbaugh@catern.com> <83eeejc8br.fsf@gnu.org> <87wnsar9tn.fsf@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13107"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 14:55:56 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf01M-0003Hs-Ih for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 14:55:56 +0200 Original-Received: from localhost ([::1]:40070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf01L-0000ci-Kc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 08:55:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf00W-0008MB-JO for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 08:55:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60415) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lf00U-0007gw-IU for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 08:55:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lf00U-0006SP-F0 for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 08:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 12:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162039207824790 (code B ref 48264); Fri, 07 May 2021 12:55:02 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 7 May 2021 12:54:38 +0000 Original-Received: from localhost ([127.0.0.1]:43724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf006-0006Rm-If for submit@debbugs.gnu.org; Fri, 07 May 2021 08:54:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf005-0006Rg-8y for 48264@debbugs.gnu.org; Fri, 07 May 2021 08:54:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47000) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lezzz-0007Nl-Sg; Fri, 07 May 2021 08:54:31 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1691 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1lezzz-0005Hx-Gs; Fri, 07 May 2021 08:54:31 -0400 In-Reply-To: <87wnsar9tn.fsf@catern.com> (message from Spencer Baugh on Fri, 07 May 2021 08:45:56 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205927 Archived-At: > From: Spencer Baugh > Cc: 48264@debbugs.gnu.org > Date: Fri, 07 May 2021 08:45:56 -0400 > > > This moves an INLINE function from a header to a C file, which I'd > > prefer to avoid (due to all kind of subtle issues with inline > > functions). Can't you move PER_BUFFER_IDX to the header instead? > > You may have misread; PER_BUFFER_IDX and PER_BUFFER_VALUE_P are both > still in the header. Yes, sorry about that.