From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49271: 28.0.50: native-comp: Signing macOS self-contained .app bundle fails due to new *.eln location Date: Thu, 01 Jul 2021 22:03:09 +0300 Message-ID: <83y2apkgb6.fsf@gnu.org> References: <83zgv7mtly.fsf@gnu.org> <83v95uld6n.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27045"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contact@jimeh.me, 49271@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 01 21:04:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lz1yw-0006mm-9Q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Jul 2021 21:04:14 +0200 Original-Received: from localhost ([::1]:49856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lz1yv-0000vT-6Z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Jul 2021 15:04:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lz1yj-0000u6-Vj for bug-gnu-emacs@gnu.org; Thu, 01 Jul 2021 15:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lz1yj-0007lO-NY for bug-gnu-emacs@gnu.org; Thu, 01 Jul 2021 15:04:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lz1yj-0002sU-KK for bug-gnu-emacs@gnu.org; Thu, 01 Jul 2021 15:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jul 2021 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49271 X-GNU-PR-Package: emacs Original-Received: via spool by 49271-submit@debbugs.gnu.org id=B49271.162516620111013 (code B ref 49271); Thu, 01 Jul 2021 19:04:01 +0000 Original-Received: (at 49271) by debbugs.gnu.org; 1 Jul 2021 19:03:21 +0000 Original-Received: from localhost ([127.0.0.1]:33714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz1y5-0002rZ-3K for submit@debbugs.gnu.org; Thu, 01 Jul 2021 15:03:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz1y3-0002rN-M9 for 49271@debbugs.gnu.org; Thu, 01 Jul 2021 15:03:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58948) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lz1xw-0007ME-7v; Thu, 01 Jul 2021 15:03:12 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1751 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lz1xv-000198-S6; Thu, 01 Jul 2021 15:03:12 -0400 In-Reply-To: (message from Alan Third on Thu, 1 Jul 2021 19:45:46 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209284 Archived-At: > Date: Thu, 1 Jul 2021 19:45:46 +0100 > From: Alan Third > Cc: contact@jimeh.me, 49271@debbugs.gnu.org > > > It should work, although I'd prefer writing such code the other way > > around: first create an uninitialized Lisp string (with > > make_uninit_multibyte_string or make_uninit_string), then copy the > > bytes while making the conversions. The reason for this preference is > > that you could then make sure the produced string has the same > > multibyte-ness as the original, whereas the way you did it relies on > > whatever build_string decides, which is not necessarily the same. > > Thanks. I think the attached is doing what you suggested. Yes. But I think you can simplify (and make it a tad faster) if you just copy bytes in either case. Since a multibyte string is represented by a superset of UTF-8, you are guaranteed that no multibyte sequence will ever include '.'. So converting from multibyte sequences to characters and back, as well as calls to string_char_advance, can be avoided. Thanks.