From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select Date: Sun, 25 Jul 2021 12:16:42 +0300 Message-ID: <83y29uwy6d.fsf@gnu.org> References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2462"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattiase@acm.org, juri@linkov.net, 39121@debbugs.gnu.org, tino.calancha@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 25 11:17:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7aFz-0000R4-IW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 11:17:11 +0200 Original-Received: from localhost ([::1]:46896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7aFy-0000MO-F2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 05:17:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7aFr-0000L0-P7 for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 05:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36055) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7aFq-0006Fc-PE for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 05:17:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7aFq-0003pX-HH for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 05:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jul 2021 09:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39121 X-GNU-PR-Package: emacs Original-Received: via spool by 39121-submit@debbugs.gnu.org id=B39121.162720462114712 (code B ref 39121); Sun, 25 Jul 2021 09:17:02 +0000 Original-Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 09:17:01 +0000 Original-Received: from localhost ([127.0.0.1]:47601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7aFo-0003pD-HY for submit@debbugs.gnu.org; Sun, 25 Jul 2021 05:17:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7aFn-0003p0-0K for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 05:16:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34404) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7aFg-00068p-NJ; Sun, 25 Jul 2021 05:16:52 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2686 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7aFg-00006t-9D; Sun, 25 Jul 2021 05:16:52 -0400 In-Reply-To: <87czr6zyid.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 25 Jul 2021 08:41:14 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210699 Archived-At: > From: Lars Ingebrigtsen > Date: Sun, 25 Jul 2021 08:41:14 +0200 > Cc: Juri Linkov , 39121@debbugs.gnu.org, > Tino Calancha > > Mattias Engdegård writes: > > > All right, this might work. Patch! > > Skimming the patch, it makes sense to me. (But I didn't try it.) > > > The immediate visible benefit is that all matches on the same line are > > highlighted, not just the first one. It also fixes the compatibility > > problems mentioned above by removing occur-highlight-regexp entirely. > > > > External packages that populate occur-mode buffers themselves should > > still work, since the old `occur-target` property format is still > > recognised. In those cases we just highlight from the first match to > > the end of the line. > > Great; go ahead and push. > > (And I see that `occur-highlight-regexp' was introduced after emacs-27, > so it's indeed OK to just remove it like your patch does.) Should we say something about these changes in NEWS?