From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50041: Add font-lock-doc-markup-face Date: Fri, 13 Aug 2021 18:57:02 +0300 Message-ID: <83y295banl.fsf@gnu.org> References: <837dgpcx1g.fsf@gnu.org> <1A815899-9854-4042-B4C1-BCF85BF4E794@acm.org> <8335rdcu1p.fsf@gnu.org> <5FDD6903-3ECB-4F3E-90D8-FA591A5A143D@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14097"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 50041@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 13 17:58:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEZZU-0003SQ-3O for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Aug 2021 17:58:12 +0200 Original-Received: from localhost ([::1]:54866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEZZS-0006Jn-LQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Aug 2021 11:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEZZK-0006Ir-Ng for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 11:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEZZK-00069y-HC for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 11:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mEZZK-0006L4-GK for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 11:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Aug 2021 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50041 X-GNU-PR-Package: emacs Original-Received: via spool by 50041-submit@debbugs.gnu.org id=B50041.162887025824324 (code B ref 50041); Fri, 13 Aug 2021 15:58:02 +0000 Original-Received: (at 50041) by debbugs.gnu.org; 13 Aug 2021 15:57:38 +0000 Original-Received: from localhost ([127.0.0.1]:42975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEZYr-0006KD-Vb for submit@debbugs.gnu.org; Fri, 13 Aug 2021 11:57:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:32946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEZYm-0006Jv-QD for 50041@debbugs.gnu.org; Fri, 13 Aug 2021 11:57:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46490) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEZYh-0005iE-69; Fri, 13 Aug 2021 11:57:23 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2141 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEZYf-0008F8-Vc; Fri, 13 Aug 2021 11:57:23 -0400 In-Reply-To: <5FDD6903-3ECB-4F3E-90D8-FA591A5A143D@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Fri, 13 Aug 2021 16:34:25 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211779 Archived-At: > From: Mattias Engdegård > Date: Fri, 13 Aug 2021 16:34:25 +0200 > Cc: larsi@gnus.org, 50041@debbugs.gnu.org > > Sure! Here is a Java doc comment: > > /** > * Wag the dog. > * @return true iff the dog was already wagged. > */ > > Here, it would be reasonable to set @return, and in font-lock-doc-markup-face since these are markup elements; the rest of the comment would be in font-lock-doc-face. And indeed, this is precisely what java-mode does today given the new face. So this face is for portions of the buffer that are markup for the text intended to be extracted into the documentation, like JavaDoc or Doxygen do? If so, I think the NEWS entry and the doc string should say so, at least as an example of the intended usage. I've read the doc string you suggested several time, and still couldn't figure out what the face is for: the description seems too abstract. > Without the face it uses font-lock-constant-face I'd expect font-lock-comment-face, what am I missing? Thanks.