unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 50572@debbugs.gnu.org, andrewjmoreton@gmail.com,
	manuel@ledu-giraud.fr, dgutov@yandex.ru
Subject: bug#50572: 28.0.50; [PATCH] fix VC to find the responsible backend with the most specific path.
Date: Thu, 11 Nov 2021 09:06:07 +0200	[thread overview]
Message-ID: <83y25v189s.fsf@gnu.org> (raw)
In-Reply-To: <87zgqbe6xu.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu,  11 Nov 2021 03:56:29 +0100)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: dgutov@yandex.ru,  50572@debbugs.gnu.org,  andrewjmoreton@gmail.com,
>   manuel@ledu-giraud.fr
> Date: Thu, 11 Nov 2021 03:56:29 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > We can always use "/\\" as SEPARATORS on MS-Windows, can't we?
> 
> I was wondering about that -- are both of those characters disallowed in
> file name components on Windows?

Yes.  Windows APIs recognize '/' as (another) directory separator, and
so using it in file names is not allowed.

> If so, then yes.  What would be the test to identify the systems
> where this is the case?

 (memq system-type '(windows-nt ms-dos))

> > But if we want a function that returns the "depth" of a file in a
> > filesystem, then it will need to call expand-file-name internally
> > anyway, for the same reason I point out above, right?
> 
> Yes.  This function can be used as a component in that calculation, but
> if that's the purpose of the call, then the caller has to make the file
> name non-relative first.

If we will require the caller to provide an absolute file name, then
why not call expand-file-name internally?  We are not saving anyone
from any potentially expensive operation, because ensuring a file name
is an absolute one without calling expand-file-name is notoriously
hard and unreliable in Emacs.  So in practice, if the requirement is
to provide an absolute file name, the callers will always call
expand-file-name anyway.





  reply	other threads:[~2021-11-11  7:06 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 15:47 bug#50572: 28.0.50; [PATCH] fix VC to find the responsible backend with the most specific path Manuel Giraud
2021-09-13 16:10 ` Eli Zaretskii
2021-09-13 23:48   ` Dmitry Gutov
2021-09-14  2:28     ` Eli Zaretskii
2021-09-14  7:57     ` Manuel Giraud
2021-09-14  7:50   ` Manuel Giraud
2021-09-14 11:38     ` Eli Zaretskii
2021-09-14 12:08       ` Manuel Giraud
2021-09-14 12:57         ` Eli Zaretskii
2021-09-14 15:15       ` Manuel Giraud
2021-09-14 16:03         ` Eli Zaretskii
2021-09-15  9:17           ` Manuel Giraud
2021-09-15 10:35           ` Dmitry Gutov
2021-09-15 11:20             ` Eli Zaretskii
2021-09-15 11:36               ` Dmitry Gutov
2021-09-15 10:41       ` Dmitry Gutov
2021-09-15 11:22         ` Eli Zaretskii
2021-09-15 11:37           ` Dmitry Gutov
2021-09-15 11:44             ` Eli Zaretskii
2021-09-15 11:47               ` Dmitry Gutov
2021-09-16 12:55                 ` Lars Ingebrigtsen
2021-11-06  0:16 ` Lars Ingebrigtsen
2021-11-06 15:01   ` Andy Moreton
2021-11-06 18:19     ` Lars Ingebrigtsen
2021-11-06 22:30       ` Andy Moreton
2021-11-06 22:35         ` Dmitry Gutov
2021-11-07 13:17           ` Lars Ingebrigtsen
2021-11-08  9:28             ` Manuel Giraud
2021-11-08  9:31               ` Lars Ingebrigtsen
2021-11-08 10:37                 ` Manuel Giraud
2021-11-09  3:29                   ` Lars Ingebrigtsen
2021-11-09  8:09                     ` Juri Linkov
2021-11-09 22:55                       ` Lars Ingebrigtsen
2021-11-09  8:51                     ` Manuel Giraud
2021-11-09 23:30                       ` Lars Ingebrigtsen
2021-11-10  0:06                         ` Dmitry Gutov
2021-11-10  0:20                           ` Lars Ingebrigtsen
2021-11-10  0:29                             ` Dmitry Gutov
2021-11-10  0:39                               ` Lars Ingebrigtsen
2021-11-10 12:54                                 ` Eli Zaretskii
2021-11-10 12:59                                   ` Lars Ingebrigtsen
2021-11-10 14:23                                     ` Eli Zaretskii
2021-11-11  2:56                                       ` Lars Ingebrigtsen
2021-11-11  7:06                                         ` Eli Zaretskii [this message]
2021-11-11  7:46                                           ` Michael Albinus
2021-11-11  8:04                                             ` Eli Zaretskii
2021-11-11 10:46                                               ` Michael Albinus
2021-11-11 12:21                                           ` Lars Ingebrigtsen
2021-11-11 15:09                                             ` Eli Zaretskii
2021-11-12  3:01                                               ` Lars Ingebrigtsen
2021-11-12  9:51                         ` Manuel Giraud
2021-11-12 12:05                           ` Eli Zaretskii
2021-11-12 15:09                             ` Manuel Giraud
2021-11-12 15:20                               ` Eli Zaretskii
2021-11-12 15:41                                 ` Manuel Giraud
2021-11-12 19:21                                 ` Manuel Giraud
2021-11-12 19:40                                   ` Eli Zaretskii
2021-11-14  0:51                                   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y25v189s.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=50572@debbugs.gnu.org \
    --cc=andrewjmoreton@gmail.com \
    --cc=dgutov@yandex.ru \
    --cc=larsi@gnus.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).