From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer Date: Thu, 25 Nov 2021 12:59:15 +0200 Message-ID: <83y25c5wn0.fsf@gnu.org> References: <87czmr5gr7.fsf.ref@yahoo.com> <87czmr5gr7.fsf@yahoo.com> <612d659daa29af13c2e5@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2479"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, larsi@gnus.org, 52053@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 25 12:00:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqCU9-0000VO-54 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Nov 2021 12:00:13 +0100 Original-Received: from localhost ([::1]:36220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqCU6-00015h-Vd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Nov 2021 06:00:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqCTy-00013g-Cl for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 06:00:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44360) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqCTy-0007IK-2e for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 06:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mqCTx-0001K3-VX for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 06:00:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Nov 2021 11:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52053 X-GNU-PR-Package: emacs Original-Received: via spool by 52053-submit@debbugs.gnu.org id=B52053.16378379625016 (code B ref 52053); Thu, 25 Nov 2021 11:00:01 +0000 Original-Received: (at 52053) by debbugs.gnu.org; 25 Nov 2021 10:59:22 +0000 Original-Received: from localhost ([127.0.0.1]:55906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqCTK-0001Iq-2K for submit@debbugs.gnu.org; Thu, 25 Nov 2021 05:59:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqCTI-0001Ie-PJ for 52053@debbugs.gnu.org; Thu, 25 Nov 2021 05:59:21 -0500 Original-Received: from [2001:470:142:3::e] (port=36662 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqCTD-00069C-DE; Thu, 25 Nov 2021 05:59:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=88+l2JDcHkB8bTGpfB9740qujJYFonOSfMdCevxsxkw=; b=HR2n16YHXglH 8R+14g37GdWkNMtYNbHiZE1v5Q1ju/Jsoh+HLweay2XGMHAaCgX+g4zsXwzYBtywhKghejyff3Ccn 3dWSnL2MOsLL9c876bAGJ0vmE2SPuEQD2Cfscew3eaZRTEcn1jxlT8gc+FZq6AcCr5Lf/1ZD21iAv 2B9y8ZxWAswVyVIjJVoCbAt0xLUiAyEQYu8fiSxwnJnOhttgiqXsEmrXO5cAsu3b9P7X4IELdHw5C zkKNqFP1lGqnnGWWKiKS86guEySVJOXmBUMpK8dnx49sSXKKwBY2eYgGXJiSRugEE3ovKyOh3Kufk goWK0liBEJCi3l3Y+YZbHA==; Original-Received: from [87.69.77.57] (port=1791 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqCTC-0005CZ-Nz; Thu, 25 Nov 2021 05:59:15 -0500 In-Reply-To: <612d659daa29af13c2e5@heytings.org> (message from Gregory Heytings on Thu, 25 Nov 2021 10:23:38 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220811 Archived-At: > Date: Thu, 25 Nov 2021 10:23:38 +0000 > From: Gregory Heytings > Cc: Lars Ingebrigtsen , 52053@debbugs.gnu.org > > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -1105,7 +1105,9 @@ substitute-command-keys > ;; itself. > (let ((keymap overriding-local-map) > (inhibit-modification-hooks t) > - (orig-buf (current-buffer))) > + (orig-buf (current-buffer)) > + (in-help (eq (car temp-buffer-window-setup-hook) > + 'help-mode-setup))) Thanks, but I'd prefer a less obscure way of telling whether this is going into *Help* buffers. Is this really the only way? Or maybe the mouse-face etc. should not be put as part of substitute-command-keys, but by the Help mode itself, when the text is already in the *Help* buffer? As we use substitute-command-keys more and more, these problems will probably pop up more and more, so maybe we should rethink whether this part is really something it should do.