From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: monnier@iro.umontreal.ca, 52385@debbugs.gnu.org
Subject: bug#52385: 29.0.50; Doc-View can't view separate pages in separate windows
Date: Sat, 18 Dec 2021 11:11:34 +0200 [thread overview]
Message-ID: <83y24ib7ll.fsf@gnu.org> (raw)
In-Reply-To: <86ee6c5upv.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 16 Dec 2021 19:04:12 +0200)
> From: Juri Linkov <juri@linkov.net>
> Date: Thu, 16 Dec 2021 19:04:12 +0200
> Cc: 52385@debbugs.gnu.org
>
> But the regression is in overlay window priorities:
> when two overlays with 'window' properties are added
> over the same region, then in 27.2 the overlay where
> the overlay window matches the selected window is preferred
> over the overlay with another window. But in 28.0.90
> the first overlay always wins.
>
> Here is the shortest test case:
>
> (let ((o1 (make-overlay (point-min) (point-max) nil t))
> (o2 (make-overlay (point-min) (point-max) nil t)))
> (overlay-put o1 'window (selected-window))
> (overlay-put o1 'display '(image :type xpm :file "left-arrow.xpm"))
> (select-window (split-window))
> (overlay-put o2 'window (selected-window))
> (overlay-put o2 'display '(image :type xpm :file "right-arrow.xpm")))
Thanks for the recipe.
> In 27.2 it displays different images in different windows. But
> in 28.0.90 only one images is displayed in both windows.
In fact, the problem existed only in Emacs 29, on the master branch.
Emacs 28 behaves correctly.
Lars, this happened due to one of the changes you made as part of
installing the support for the 'min-width' space display spec: a small
code fragment was moved inside handle_display_prop, in a way that
disabled the selection of overlays specific to windows, when those
overlays have the 'display' property.
I moved that code fragment back to where it belongs, and tested that
min-width still seems to work, both on the mode line and in the
xdisp-tests.el. If you know about any other situation where that move
of the code was necessary, please show the recipe or tell the details.
Otherwise, this bug should be fixed now on the master branch.
next prev parent reply other threads:[~2021-12-18 9:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 4:20 bug#52385: 29.0.50; Doc-View can't view separate pages in separate windows Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-10 11:55 ` Lars Ingebrigtsen
2021-12-10 15:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-11 3:23 ` Lars Ingebrigtsen
2021-12-11 18:46 ` Juri Linkov
2021-12-16 17:04 ` Juri Linkov
2021-12-16 17:44 ` Eli Zaretskii
2021-12-16 19:33 ` Juri Linkov
2021-12-16 20:09 ` Eli Zaretskii
2021-12-17 8:29 ` Juri Linkov
2021-12-17 12:08 ` Eli Zaretskii
2021-12-18 17:18 ` Juri Linkov
2021-12-18 9:11 ` Eli Zaretskii [this message]
2021-12-19 10:37 ` Lars Ingebrigtsen
2021-12-19 13:49 ` Eli Zaretskii
2021-12-19 13:54 ` Lars Ingebrigtsen
2021-12-19 14:09 ` Eli Zaretskii
2021-12-19 17:12 ` Juri Linkov
2021-12-19 17:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y24ib7ll.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=52385@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).