From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Date: Sat, 19 Feb 2022 19:22:36 +0200 Message-ID: <83y226ydnn.fsf@gnu.org> References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> <83a6enyrdh.fsf@gnu.org> <54befa08-3bce-1d86-4e8b-e3cc4246da0b@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21083"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, juri@linkov.net, 53910@debbugs.gnu.org, monnier@iro.umontreal.ca, spacibba@aol.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 19 18:23:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLTRy-0005Jq-Mw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Feb 2022 18:23:14 +0100 Original-Received: from localhost ([::1]:33956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLTRx-0008SI-Fn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Feb 2022 12:23:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLTRn-0008Rr-2j for bug-gnu-emacs@gnu.org; Sat, 19 Feb 2022 12:23:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36538) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nLTRm-0004EX-OX for bug-gnu-emacs@gnu.org; Sat, 19 Feb 2022 12:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nLTRm-00037w-Ka for bug-gnu-emacs@gnu.org; Sat, 19 Feb 2022 12:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Feb 2022 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53910 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 53910-submit@debbugs.gnu.org id=B53910.164529137711989 (code B ref 53910); Sat, 19 Feb 2022 17:23:02 +0000 Original-Received: (at 53910) by debbugs.gnu.org; 19 Feb 2022 17:22:57 +0000 Original-Received: from localhost ([127.0.0.1]:58667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLTRd-00037F-9u for submit@debbugs.gnu.org; Sat, 19 Feb 2022 12:22:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLTRY-000370-RM for 53910@debbugs.gnu.org; Sat, 19 Feb 2022 12:22:52 -0500 Original-Received: from [2001:470:142:3::e] (port=36948 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLTRS-00045a-4r; Sat, 19 Feb 2022 12:22:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j8hrMD+z63z5KYcU3Nx+zUatA/pgzr+P3zJYXeRw7sc=; b=LVarGcz0taVT /Q8Qors7jPed17B+loifK6iztH3U0pQOqny7saPHLgqdZhF3ZJc/sm1IGazXUIHbopnlFwDV/uM+D TFemk1EwhHBoFRDdxZyRHKVt4Z1u0lxNQ1yEIBe+yNujR4nfDh8ehJ2cjjlpN9hmo0Ck+HgIH2/uG zjeUAPzVDbmb7WypoUJ6BXlRumn7ZE2lOZaSkow10ujB9xpiz9zw/xUhVpWHKVEVnvmoKOpGsvEax vo+LmEfMZ72pI+Qd4ii5R9R+xSXvoW3cfRK/ydAVRE5pMlM96mC6eCE3SHIA4KQjj+HsxkYa46X/f j5O4J5UtZ6UCu+XgnO32hg==; Original-Received: from [87.69.77.57] (port=3489 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLTRQ-0005Rx-7f; Sat, 19 Feb 2022 12:22:41 -0500 In-Reply-To: <54befa08-3bce-1d86-4e8b-e3cc4246da0b@gmx.at> (message from martin rudalics on Sat, 19 Feb 2022 18:07:03 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227198 Archived-At: > Date: Sat, 19 Feb 2022 18:07:03 +0100 > Cc: juri@linkov.net, monnier@iro.umontreal.ca, larsi@gnus.org, > spacibba@aol.com, 53910@debbugs.gnu.org > From: martin rudalics > > > What exactly do you mean by "interactive use only"? Several commands > > invoke bury-buffer as part of their job -- or do you consider that to > > be "interactive use" as well? > > No. Consider the following two forms: > > (defun foo (&optional buffer) > (interactive) > (let ((buffer (window-normalize-buffer buffer))) > (if (or (and (window-next-sibling) > (eq (window-buffer (window-next-sibling)) buffer)) > (and (window-prev-sibling) > (eq (window-buffer (window-prev-sibling)) buffer))) > (bury-buffer buffer) > (kill-buffer buffer)))) > > (defun foo (&optional buffer) > (interactive) > (if (let ((buffer (window-normalize-buffer buffer))) > (or (and (window-next-sibling) > (eq (window-buffer (window-next-sibling)) buffer)) > (and (window-prev-sibling) > (eq (window-buffer (window-prev-sibling)) buffer)))) > (bury-buffer buffer) > (kill-buffer buffer))) > > If, after C-x 2, I do M-x foo, the first will leave the windows' buffers > unchanged while the second will show another buffer in the selected > window. So my conclusion is to never use 'bury-buffer' in Lisp code. That bury-buffer can be mis-used or abused doesn't mean it should not be used correctly, especially since we do that in many places. Moreover, bury-buffer does little besides bury-buffer-internal, so I still don't understand the emotional reaction.