From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54636: dired fails to update subdirs when files are created/deleted/renamed Date: Wed, 30 Mar 2022 19:30:20 +0300 Message-ID: <83y20r768z.fsf@gnu.org> References: <877d8b3d4w.fsf@igel.home> <87y20r1vys.fsf@igel.home> <87o81n1ue5.fsf@gnu.org> <835ynv8ti4.fsf@gnu.org> <87k0cb1rpa.fsf@gnu.org> <831qyj8rxl.fsf@gnu.org> <87czi31p1l.fsf@gnu.org> <83zgl7780z.fsf@gnu.org> <878rsr1kss.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17037"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54636@debbugs.gnu.org, schwab@linux-m68k.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 30 18:31:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbE5-0004Dm-5Q for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 18:31:17 +0200 Original-Received: from localhost ([::1]:59666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZbE3-0001O4-TW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 12:31:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZbDq-0001NU-U7 for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 12:31:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42862) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZbDq-0001AB-Lf for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 12:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZbDq-0007O3-CN for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 12:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2022 16:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54636 X-GNU-PR-Package: emacs Original-Received: via spool by 54636-submit@debbugs.gnu.org id=B54636.164865784627387 (code B ref 54636); Wed, 30 Mar 2022 16:31:02 +0000 Original-Received: (at 54636) by debbugs.gnu.org; 30 Mar 2022 16:30:46 +0000 Original-Received: from localhost ([127.0.0.1]:36754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZbDa-00077M-8H for submit@debbugs.gnu.org; Wed, 30 Mar 2022 12:30:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZbDX-0006yj-OH for 54636@debbugs.gnu.org; Wed, 30 Mar 2022 12:30:44 -0400 Original-Received: from [2001:470:142:3::e] (port=38986 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZbDR-00015J-VM; Wed, 30 Mar 2022 12:30:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ed5iVdqrYNQEi08xYej/hu7aIcyMKkvd95uij+yvyxQ=; b=G3UEwTm/dTKJ Dijt33zmFVC826Pi4nlJ1/Yupqjpmwyauq7g8MoYMKmARk0Y0gG/j0b3sN9yGJtYoUFWOKfERqaCe n8vzGYYnqmKvLyMLb/+dx9IZrslZBA2JDWfmesZKC+M71UfCUA18veXPGtuwEEns1EsC/uPSgARFM kkA30Yjr/XZCdlCgXJEAognXKyLTmlVDKvTXZmObfHms0DhCfzmYBXjW4stTeSGTlqjHLCKg//imJ t1gTpTbnk85lNg2kP4+dyKDmk9efJR76wAs9l3BPfrhDIn93cczgIy+96TuRksc417suWfyLfi17w F4UlHkH3YHJySyAkjCl9cw==; Original-Received: from [87.69.77.57] (port=4659 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZbD2-0005JD-PZ; Wed, 30 Mar 2022 12:30:34 -0400 In-Reply-To: <878rsr1kss.fsf@gnu.org> (message from Tassilo Horn on Wed, 30 Mar 2022 18:02:15 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229120 Archived-At: > From: Tassilo Horn > Cc: schwab@linux-m68k.org, 54636@debbugs.gnu.org > Date: Wed, 30 Mar 2022 18:02:15 +0200 > > Eli Zaretskii writes: > > > So when will SUBDIRS be non-nil? dired-clean-up-after-deletion is > > called not only when a directory is deleted, I think. > > Yes, it's also called when deleting a file but in that case > dired-buffers-for-dir will return nil, so no buffer will be deleted. What about moving/renaming a directory? > I think my patch is valid but now I think I should just create a > separate function dired-buffers-for-cleanup and use that from > dired-clean-up-after-deletion (or just collect the buffers in that > function) and remove the SUBDIRS argument from dired-buffers-for-dir as > it changes its logic too drastically. > > I'll prepare a patch in that direction later. At this point, I'd prefer the safest, simplest patch for the release branch, because I intend to release Emacs 28.1 VSN. We can make a cleaner fix on master later. Do you think this patch you posted is safe enough for Emacs 28.1?