From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame Date: Tue, 12 Jul 2022 19:02:46 +0300 Message-ID: <83y1wywc7t.fsf@gnu.org> References: <83zghm5evt.fsf@gnu.org> <5d86d890-9a2e-e4d6-13fb-da03285ea003@gmx.at> <61fe102b-eec2-9711-560e-c141ed3cc6e4@gmx.at> <83wncjzyvs.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37586"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, 56305@debbugs.gnu.org, monnier@iro.umontreal.ca To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 12 18:05:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBINv-0009YT-33 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jul 2022 18:05:15 +0200 Original-Received: from localhost ([::1]:49712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBINt-0002yn-V2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jul 2022 12:05:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBIMl-0002FP-1G for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2022 12:04:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49683) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oBIMk-0001PE-GE for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2022 12:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oBIMk-0007NN-52 for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2022 12:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2022 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56305 X-GNU-PR-Package: emacs Original-Received: via spool by 56305-submit@debbugs.gnu.org id=B56305.165764180028298 (code B ref 56305); Tue, 12 Jul 2022 16:04:02 +0000 Original-Received: (at 56305) by debbugs.gnu.org; 12 Jul 2022 16:03:20 +0000 Original-Received: from localhost ([127.0.0.1]:43580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBILq-0007M3-1n for submit@debbugs.gnu.org; Tue, 12 Jul 2022 12:03:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBILn-0007LY-Lm for 56305@debbugs.gnu.org; Tue, 12 Jul 2022 12:03:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBILh-0001HE-A0; Tue, 12 Jul 2022 12:02:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=89sObEac55tS2nFRrmUlym4/7OWvKrW5E0rgW/IGxTc=; b=rUp+gtQjg4gh kDrC3GngzsznEr6KcQ/JUnN1ykNdf8wJG9YZzL1f77QztyMybeGQS2ZzbjP4JTsf80eG1JqpaKY1k LDfcd5r0zqnHn7n2mBQRk4dG1oYue94vpcar0qW1zy4dtVbSlsEFfbqg9xUG78A3SQ734ift/YufG sPqthJpolFnMUvu1H30v0qMKsn7JOf4bWDwd3EuVq91STVhSKyrXkDJTmQ4B8QCQxzHXM7IlFre8L 2dhslIo41iktj7LL3TCEg5k9U7wieuleOvZ/rEyQTno9tA+0mYN5tcNHWt09v9nW3uJ72u3Doui47 +VHf+FVBkd0KLJaub2KuDw==; Original-Received: from [87.69.77.57] (port=4927 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBILg-00060d-Px; Tue, 12 Jul 2022 12:02:57 -0400 In-Reply-To: (message from martin rudalics on Tue, 12 Jul 2022 09:33:00 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236822 Archived-At: > Date: Tue, 12 Jul 2022 09:33:00 +0200 > Cc: acm@muc.de, monnier@iro.umontreal.ca, 56305@debbugs.gnu.org > From: martin rudalics > > > Can you tell how inhibit-redisplay is related to the original recipe > > in this bug? Specifically, at what point is inhibit-redisplay set in > > that recipe and by which code? > > It's all explained here in gui_consider_frame_title: > > /* select-frame calls resize_mini_window, which could resize the > mini-window and by that undo the effect of this redisplay > cycle wrt minibuffer and echo-area display. Binding > inhibit-redisplay to t makes the call to resize_mini_window a > no-op, thus avoiding the adverse side effects. */ > > /* The following was moved before the record_unwind_protect form > below to inhibit redisplay also when restoring the selected > window/frame: This avoids that resize_mini_window sizes back > the minibuffer window of a temporarily selected frame. See > Bug#34317. */ > specbind (Qinhibit_redisplay, Qt); OK, but then we should have a comment pointing to this in the change you proposed for emacs-28, and I agree to fix the problem as you suggested with that comment added. Thanks.