From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation Date: Thu, 21 Jul 2022 15:33:52 +0300 Message-ID: <83y1wmmyq7.fsf@gnu.org> References: <83k089m4j0.fsf@gnu.org> <8335ewm2i1.fsf@gnu.org> <83a693lhms.fsf@gnu.org> <87sfmvtn99.fsf@web.de> <838ronkpzh.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35887"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, 56643@debbugs.gnu.org, akrl@sdf.org To: defun.foo@proton.me Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 21 14:42:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEVVm-0009CS-Oq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jul 2022 14:42:38 +0200 Original-Received: from localhost ([::1]:52662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEVVl-0000As-2Z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jul 2022 08:42:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEVOQ-0008MB-U1 for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2022 08:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47108) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oEVOQ-0005jB-Jf for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2022 08:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oEVOQ-00015k-Fd for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2022 08:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jul 2022 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56643 X-GNU-PR-Package: emacs Original-Received: via spool by 56643-submit@debbugs.gnu.org id=B56643.16584068674140 (code B ref 56643); Thu, 21 Jul 2022 12:35:02 +0000 Original-Received: (at 56643) by debbugs.gnu.org; 21 Jul 2022 12:34:27 +0000 Original-Received: from localhost ([127.0.0.1]:36857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEVNo-00014f-0a for submit@debbugs.gnu.org; Thu, 21 Jul 2022 08:34:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEVNX-00013t-6k for 56643@debbugs.gnu.org; Thu, 21 Jul 2022 08:34:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEVNR-0005cu-2H; Thu, 21 Jul 2022 08:34:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ygfpw7IMQbkhGjF11WBJSDjdNRg8iV5qninOhSKCmEQ=; b=V5iGKoIw+Vtf VQFYZULr/RCVD6dWRtIhGHqsluG/oANqFW8zTyymxE2IKlmNZ0QYBH0VMMfYm3FM2wPyZSxTr1oNO 6Iv/GNNKbLMwKQVkBx0wnG1O5CSumG5XYQjDVi5F5ak0W2jx3/7ONU2GuAdz0/VvJ10URPpYkesbv u5Rp2a4U/UGX8PRfOLeVsFTDGw+0wk2yozaw5c7l4C7VU5NM7gKgEYEuYrqPphpeP4EvD+SUybd11 pus/k8Y8xH2Ux0CQur3Hi0BAJEy5cfQ+NPqP8dT8ENyBYuC3oWy+4nvGxrBj+AnbTUbx4Y6+30rUu mIhg31vLX/FsqGV9aF+PGg==; Original-Received: from [87.69.77.57] (port=2950 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEVNQ-0001Ce-H9; Thu, 21 Jul 2022 08:34:00 -0400 In-Reply-To: (defun.foo@proton.me) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237550 Archived-At: > Date: Thu, 21 Jul 2022 10:01:57 +0000 > From: defun.foo@proton.me > Cc: Michael Heerdegen , akrl@sdf.org, 56643@debbugs.gnu.org > > > > Alternatively we could introduce a named helper function. Note there > > > are more calls of `help-setup-xref' using lambdas in arguments. > > > > > > And that would solve the problem? Did you try that? > > I tried it with describe-function and it does solve the problem, although as noted above there are many other functions that generate help buffers and pass in a lambda. I know very well there are other instances, I just wanted us to stay focused. > Named helper: > > (defun describe-function-xref-func (function buffer) > (let ((describe-function-orig-buffer > (if (buffer-live-p buffer) buffer))) > (describe-function function))) > > Revised describe-function snippet: > > (help-setup-xref > (list 'describe-function-xref-func function describe-function-orig-buffer) > (called-interactively-p 'interactive)) > > This produces the following bookmark, which I confirmed still works after restarting Emacs: > > ("named-function-help-bookmark" > (position . 1) > (last-modified 25305 7198 806743 243000) > (help-fn . describe-function-xref-func) > (help-args completing-read "*scratch*") > (position . 1) > (handler . help-bookmark-jump)) Thanks. If Andrea confirms that this won't have any problems with native-compilation, I will install such changes on the release branch (since AFAIU this issue is a regression in Emacs 28).