unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Kiên Nguyễn Quang" <kien.n.quang@gmail.com>
Cc: 57386@debbugs.gnu.org
Subject: bug#57386: 29.0.50; support make-symbolic-link without admin priviledge on Windows
Date: Thu, 25 Aug 2022 12:09:10 +0300	[thread overview]
Message-ID: <83y1vc3d1l.fsf@gnu.org> (raw)
In-Reply-To: <CAL7sU5g29vihy1V6Haz2QF=ZTSD0uDJ-BbkT1E5qN2scbD5RrQ@mail.gmail.com> (message from Kiên Nguyễn Quang on Thu, 25 Aug 2022 17:52:50 +0900)

> From: Kiên Nguyễn Quang <kien.n.quang@gmail.com>
> Date: Thu, 25 Aug 2022 17:52:50 +0900
> Cc: 57386@debbugs.gnu.org
> 
>  That's a separate problem, which we will resolve if and when it
>  becomes relevant.  For now, this problem doesn't exist, since AFAIK
>  there are no features yet which we want to use that are available only
>  in Windows 11 and later.  So please assume that version checks in
>  Emacs are reliable, and always will be, no matter what MS says about
>  that.
> 
>  Thanks.
> 
> The new flag is available starting from Windows 10 Creator update, which means two (or 3? I don't know)
> updates after the first Windows 10 release.
> Since the version returned for all Windows 10 are the same, you see, that's the problem.

If that's the problem (is anyone who has Windows 10 still likely to
use those old releases, given the automatic updates in Windows 10 that
cannot be turned off? and if they do, do they indeed get
ERROR_INVALID_PARAMETER?), we can handle that as well.  We have
already an API for accessing the Registry (see w32-read-registry and
its C counterpart w32_read_registry), and report-emacs-bug already
uses it to obtain the full description of the version, the build
number and all.  If needed, we can use a similar technique to make an
accurate version test.

> I think the error is already caught and should be replaced with the new one if we retry calling the API, can you
> elaborate more on how it can still affect Emacs?

When you call an API with a parameter that is invalid, you are risking
an exception, depending on the API and the build (debug or not).  This
has various unpleasant consequences; in the worst case, the Emacs
process could be terminated.  As documented, the problem is limited to
CRT functions, but our general policy is to avoid that even when using
the Win32 APIs.  And version check is a simple enough way of avoiding
that, so I see no reason not to do it here.





  reply	other threads:[~2022-08-25  9:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24 15:33 bug#57386: 29.0.50; support make-symbolic-link without admin priviledge on Windows Kiên Nguyễn Quang
2022-08-24 16:00 ` Eli Zaretskii
2022-08-24 18:05   ` Kiên Nguyễn Quang
2022-08-24 18:26     ` Eli Zaretskii
2022-08-25  1:30       ` Kiên Nguyễn Quang
2022-08-25  5:50         ` Eli Zaretskii
2022-08-25  8:52           ` Kiên Nguyễn Quang
2022-08-25  9:09             ` Eli Zaretskii [this message]
2022-08-25  9:51               ` Kiên Nguyễn Quang
2022-08-25  9:57                 ` Eli Zaretskii
2022-08-25 10:32                   ` Kiên Nguyễn Quang
2022-08-25 13:22                     ` Eli Zaretskii
2022-08-25 11:35                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-25 12:59                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y1vc3d1l.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=57386@debbugs.gnu.org \
    --cc=kien.n.quang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).