From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57607: Feature request: Use the character cell on bottom-right corner of a terminal Date: Mon, 03 Oct 2022 22:41:39 +0300 Message-ID: <83y1twwv7w.fsf@gnu.org> References: <87wnakl5md.fsf@disroot.org> <87o7vt3s58.fsf@disroot.org> <87ilm04xzl.fsf@disroot.org> <875yi0v8r6.fsf@disroot.org> <874jxjhz9l.fsf@disroot.org> <87tu5i9kbg.fsf@disroot.org> <87r0zpi9za.fsf@disroot.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18804"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 57607@debbugs.gnu.org To: Akib Azmain Turja Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 03 22:33:52 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofS8M-0004h8-Qx for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Oct 2022 22:33:51 +0200 Original-Received: from localhost ([::1]:44898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofS8L-0001n8-JQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Oct 2022 16:33:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofRKK-00028e-3s for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2022 15:42:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ofRKE-0005DY-TX for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2022 15:42:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ofRKE-0001PZ-Hz for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2022 15:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Oct 2022 19:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57607 X-GNU-PR-Package: emacs Original-Received: via spool by 57607-submit@debbugs.gnu.org id=B57607.16648261145410 (code B ref 57607); Mon, 03 Oct 2022 19:42:02 +0000 Original-Received: (at 57607) by debbugs.gnu.org; 3 Oct 2022 19:41:54 +0000 Original-Received: from localhost ([127.0.0.1]:51752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofRK6-0001PC-7i for submit@debbugs.gnu.org; Mon, 03 Oct 2022 15:41:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofRK4-0001Ox-0a for 57607@debbugs.gnu.org; Mon, 03 Oct 2022 15:41:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49670) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofRJy-0005Ct-Pw; Mon, 03 Oct 2022 15:41:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5vUdb6fdIrdmCO0yY4k7NXVfwXO2JiLytfYpu4e5f8U=; b=POl+jZe89GV+ 8gyzASKSnaZ99M09/j4wC+1YR1xSraLH7s6giC/URAUjYtbskHLwLqNjnfT3QV8YcOv5FLUQP81ls GmSFuRJkbn6Gw8bWkbqS4UZpPiPEezC5GCnrJ6PSAvBT0BfYg81yyZIpxAKA2/17bum0jtgfPp99n QeXFYbb1FFrRIwhMLTaeqqJajl6vqAWjQrW/9QiE6dwLNKHyNGMArSwCWhsRcypciiS2hkR3Az2/a R+gwXwDDMR2/eE+8ppg0rtN107gBvnJlbd0m27pIQY3cdiNyj4zM2GcdRymKquCqcaYPiGymVBbp7 HwN4vIWMxiv5J6uIP53hQw==; Original-Received: from [87.69.77.57] (port=1433 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofRJx-0002wR-KB; Mon, 03 Oct 2022 15:41:46 -0400 In-Reply-To: <87r0zpi9za.fsf@disroot.org> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244332 Archived-At: > Cc: gerd.moellmann@gmail.com > Date: Mon, 03 Oct 2022 14:31:53 +0600 > From: Akib Azmain Turja via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I have implemented it. Implementing it was easier than I thought. Here > is the patch: Thanks. But could you please describe the idea of the patch in some comment? It is hard to follow the code, especially since the diff has many pure whitespace changes. Also, this: > + /* Go to the previous position. */ > + cmgoto (tty, curY (tty), curX (tty) - 1); > + cmplus (tty, 1); Seem to assume the last character takes just one column? What about characters whose width is 2 columns? And finally, it would be nice to avoid so much code duplication between tty_write_glyphs and tty_write_glyphs_with_face. Is that feasible?