From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type Date: Sat, 22 Oct 2022 14:45:39 +0300 Message-ID: <83y1t8t730.fsf@gnu.org> References: <87v8orky2u.fsf@gnus.org> <20221021210636.13329-1-jonas@bernoul.li> <20221021210636.13329-2-jonas@bernoul.li> <83czakuziw.fsf@gnu.org> <874jvwrvbl.fsf@bernoul.li> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4149"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58363@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 22 13:53:03 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omD3m-0000uo-BL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Oct 2022 13:53:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omCy6-0001H7-Ba; Sat, 22 Oct 2022 07:47:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omCxz-0001G4-P6 for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 07:47:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omCxy-0005AN-Qy for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 07:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omCxy-0004FA-9M for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 07:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2022 11:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58363 X-GNU-PR-Package: emacs Original-Received: via spool by 58363-submit@debbugs.gnu.org id=B58363.166643919516278 (code B ref 58363); Sat, 22 Oct 2022 11:47:02 +0000 Original-Received: (at 58363) by debbugs.gnu.org; 22 Oct 2022 11:46:35 +0000 Original-Received: from localhost ([127.0.0.1]:39833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omCxW-0004EU-Sc for submit@debbugs.gnu.org; Sat, 22 Oct 2022 07:46:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omCxR-0004ED-FS for 58363@debbugs.gnu.org; Sat, 22 Oct 2022 07:46:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omCxK-00050y-15; Sat, 22 Oct 2022 07:46:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dIME3ZVtC+YYoOwRm72qxaAegH3Sm2G+1Tb6dAuGDEk=; b=A0rGmfnknvwp SZkPV8C/1dpJf/JE/6R+Gx3FTU9M+PNowNLtgNlj0JrJbvRpN2XMtalijdCMRKQ6/OZFKRLdTjbaI gEW9bCBQkKlt3R2xb0/DBQgYpZalT99jKACajUcOn3psWTKEbIHnVrnymnMk+gzWO18WdM8BiYzA+ p36GlqbFm8JkLCFhNwAL7MXXc2KIYynOpsbS0jylXXYPwT0BsaVZ3MGPDyvrLTVi0fCZeemQhKGol tVczvW3nwwOwwiGx0y1HCUpsJBAnrHABIWOFc0d6zIEN1YvHTjoAuosk4rBCrjh8oBaoM96op4GzL bMnYdqAFXzzVd4pYt2EUhg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omCwb-0000bv-NA; Sat, 22 Oct 2022 07:45:55 -0400 In-Reply-To: <874jvwrvbl.fsf@bernoul.li> (message from Jonas Bernoulli on Sat, 22 Oct 2022 12:45:02 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246037 Archived-At: > From: Jonas Bernoulli > Cc: 58363@debbugs.gnu.org > Date: Sat, 22 Oct 2022 12:45:02 +0200 > > Eli Zaretskii writes: > > >> - xsignal (Qerror, build_string ("Module name not on allowlist")); > >> + xsignal1 (Qerror, build_string ("Module name not on allowlist")); > > > > Why Qerror here and not Qsqlite_error? And if the more general Qerror > > is deliberate, then why not Qmodule_load_failed, for instance? > > This commit just fixes a bug. > Qsqlite_error is introduced in the next commit. This is one reason why I prefer a single patch to series of patches. (I believe Lars prefers that as well.) It avoids the need to review patches that are superseded by the following ones, especially when network delays cause the different parts of the series to be delivered out of sequence. So, unless this totally disrupts your workflows, please post patches as a single coherent changeset, bypassing intermediate steps that are later superseded. TIA.