From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59426: 29.0.50; [tree-sitter] Some functions exceed maximum recursion limit Date: Thu, 24 Nov 2022 21:28:16 +0200 Message-ID: <83y1s0up7z.fsf@gnu.org> References: <87wn7o6c9c.fsf@yahoo.com> <701BF611-6506-403E-B70B-2D93F3339E0C@acm.org> <83v8n82yzl.fsf@gnu.org> <83fsec2qq3.fsf@gnu.org> <83edtw2pz3.fsf@gnu.org> <835yf82oc4.fsf@gnu.org> <942C72E7-3DA9-4E2B-8B40-137B8FB23473@acm.org> <04236EB0-122B-41D0-B696-CC2EFA4B6A93@gmail.com> <6822E77F-3094-4E73-A7E7-EF5C096FC08F@acm.org> <104387C6-BF9A-4243-AD64-1ADCC25CBBA0@acm.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11611"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, mattiase@acm.org, stefankangas@gmail.com, 59426@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 20:29:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyHuK-0002pe-Px for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 20:29:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyHuB-00021w-Jr; Thu, 24 Nov 2022 14:29:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyHuA-00021k-Or for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 14:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyHuA-0003g8-8c for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 14:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyHuA-0006sK-4k for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 14:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59426 X-GNU-PR-Package: emacs Original-Received: via spool by 59426-submit@debbugs.gnu.org id=B59426.166931808826366 (code B ref 59426); Thu, 24 Nov 2022 19:29:02 +0000 Original-Received: (at 59426) by debbugs.gnu.org; 24 Nov 2022 19:28:08 +0000 Original-Received: from localhost ([127.0.0.1]:60235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyHtI-0006rC-0f for submit@debbugs.gnu.org; Thu, 24 Nov 2022 14:28:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyHtG-0006qi-CO for 59426@debbugs.gnu.org; Thu, 24 Nov 2022 14:28:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyHtA-0003Wx-P0; Thu, 24 Nov 2022 14:28:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=O/+xVkMZ4AqihdIvknGlr0oEORpPxRuIEGYZK49sIKI=; b=kakDE2Trq+xo jojaTMozCd75rRQUTwTpqsVfjzRXvPV7HB9Q5LNM3Xmx4t/+Ff7b2vXVYAbnIDDFJRD5XBYTmJGyv q6z25oqQXwasmCfo2n3nqf6bmmGvqgQnFwkm4miDeUE4dPm1ANxzmAYWs91J5XLMpN2QSegw0Sbs0 YgcD7iTQ7OaombaqdmJ0JscL5EQG6X1FpNFL0vjxpXdmC5n67bf/MY9PLAuOK8W8din2WuWJDWCWQ Ewek5rsfcd/FiHxtyEDylNt9WTwMEwJyQlcmXO7yBaz4IoU1ggLMQ3VqbHDsZC5TPxj832yPLWAsi cuEKCwlXO/8sIqzwd3Tp5Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyHt7-0007x5-Nu; Thu, 24 Nov 2022 14:27:59 -0500 In-Reply-To: (message from Yuan Fu on Thu, 24 Nov 2022 11:25:58 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248901 Archived-At: > From: Yuan Fu > Date: Thu, 24 Nov 2022 11:25:58 -0800 > Cc: Eli Zaretskii , > Po Lu , > Stefan Kangas , > 59426@debbugs.gnu.org > > That brings us back to the original question: what limit should we use? I suggest we use a smaller number since normal tree should never be very tall. Running the following code tells me the height of the tree for xdisp.c is 30: > > (defun measure-height (node) > (let ((children (treesit-node-children node t))) > (if children > (1+ (apply #'max (mapcar #'measure-height children))) > 1))) > ;; In xdisp.c: > (measure-height (treesit-buffer-root-node)) > > Maybe a limit in the range of hundreds or thousands? 800? I suggest 1000.