From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59842: [PATCH] Make proced-update Preserve Refinements Date: Tue, 06 Dec 2022 19:49:06 +0200 Message-ID: <83y1rk5sod.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12642"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59842@debbugs.gnu.org To: Laurence Warne Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 06 18:50:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2c5L-00033z-F7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Dec 2022 18:50:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2c4y-00045x-4K; Tue, 06 Dec 2022 12:50:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2c4w-00044s-Tx for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2022 12:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2c4w-0005wO-LJ for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2022 12:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2c4w-0006LQ-HD for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2022 12:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Dec 2022 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59842 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59842-submit@debbugs.gnu.org id=B59842.167034896824239 (code B ref 59842); Tue, 06 Dec 2022 17:50:02 +0000 Original-Received: (at 59842) by debbugs.gnu.org; 6 Dec 2022 17:49:28 +0000 Original-Received: from localhost ([127.0.0.1]:44254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2c4N-0006Ir-Q4 for submit@debbugs.gnu.org; Tue, 06 Dec 2022 12:49:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2c4L-0006I4-QR for 59842@debbugs.gnu.org; Tue, 06 Dec 2022 12:49:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2c4G-0005sn-Bn; Tue, 06 Dec 2022 12:49:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rIcEG3knjejN+Q6Jq+FxDnjMyTY+ZcYMZhmZWFkgPv4=; b=B5velqEiJOzQ swt9aPsqJxskxMeJ4WOWLpKVjsjdzG322rGj68DCExxnpD5oqwga0btuWnOzeYzWSxom2x4UY+YLt zjhI4J4ZYRHtZTcwO/AfcWheDKAe42Y09z1QMwIwVS2VHx0cO5oXCeOSkarHioQU0d4AaFniBSE5K WjnRxxlxvgYJh2kDznUAvrvTwAC0FJhdkrTlgJmVZlIuidYQWnAr6rtSjMvQKWkNUnYlNJoZEwX1u NJGUe4ujlYUwKVEnTMqcASiYtMO23O53lEs4sbBkoW7IbI5cQlM605CBbKcyLkfft3V0PJkRgGxCm kDZ48B3nUiyiZ/KwsGOOVA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2c4F-0006Ot-Np; Tue, 06 Dec 2022 12:49:20 -0500 In-Reply-To: (message from Laurence Warne on Mon, 5 Dec 2022 20:26:26 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250136 Archived-At: > From: Laurence Warne > Date: Mon, 5 Dec 2022 20:26:26 +0000 > > The patch fixes aims to fix this by introducing a new buffer local variable "proced-refinements" which stores > information about the current refinements, and is used by proced-update to further refine > proced-process-alist in the case it is non-nil. Thanks. Unfortunately, we don't have a test suite for proced.el, so non-trivial changes to it always ruin the risk of producing regressions. How to test this, and how did you test it? > * lisp/proced.el (proced-refinements): New buffer local variable > which tracks the current refinements. > (proced-refine): Set proced-refinements variable and defer setting of > proced-process-alist to proced-update. > (proced-update): Take into account proced-refinements when setting > proced-process-alist. > (proced-revert): Set proced-refinements to nil prior to calling proced-update. Please quote symbols in log entries 'like this'. (Do not quote symbols inside parentheses, only in the descriptive text.) > + (pcase-dolist (`(,refiner ,pid ,key ,grammar) proced-refinements) > + ;; It's possible the process has exited since the refinement was made > + (when (assq pid proced-process-alist) What happens if that process did exit? Shouldn't we reset proced-refinements to nil? > (defun proced-revert (&rest _args) > "Reevaluate the process listing based on the currently running processes. > -Preserves point and marks." > +Preserves point and marks, but not refinements." Please add a cross-reference to proced-refine here, so that the reader who doesn't know what a "refinement" is could find out.