From: Eli Zaretskii <eliz@gnu.org>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: 61567@debbugs.gnu.org
Subject: bug#61567: 30.0.50; Define display-time-time-and-date-indicator face
Date: Fri, 17 Feb 2023 08:37:32 +0200 [thread overview]
Message-ID: <83y1ow23wz.fsf@gnu.org> (raw)
In-Reply-To: <87zg9cx1sj.fsf@protesilaos.com> (message from Protesilaos Stavrou on Fri, 17 Feb 2023 08:07:40 +0200)
> From: Protesilaos Stavrou <info@protesilaos.com>
> Date: Fri, 17 Feb 2023 08:07:40 +0200
>
> I have written a small patch for 'time.el'. It adds a face to the
> date+time of 'M-x display-time-mode'.
>
> Should I install this on 'master'?
Yes, please.
> Any changes to make to it?
See below.
> * etc/NEWS: Announce the new face for the 'display-time-format'.
> * lisp/time.el (display-time-time-and-date-indicator): Define new face.
> (display-time-string-forms): Use the new face.
Please remember to mention the bug number in the log message when you
install this.
> +---
> +** New face for 'display-time-format'
> +The 'display-time-time-and-date-indicator' applies to the time and
> +date component of the 'display-time-mode'. By default, the face has
> +all its attributes unspecified to preserve the indicator's familiar
> +appearance.
This entry is IMO too long for such a simple and minor change. Just
saying something like
** New face 'display-time-time-and-date-indicator'.
This is used for displaying the time and date components of
'display-time-mode'.
should be enough.
> +(defface display-time-time-and-date-indicator nil
> + "Face of the `display-time-format'."
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
"Face for `display-time-format'."
Thanks.
next prev parent reply other threads:[~2023-02-17 6:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 6:07 bug#61567: 30.0.50; Define display-time-time-and-date-indicator face Protesilaos Stavrou
2023-02-17 6:37 ` Eli Zaretskii [this message]
2023-02-17 10:16 ` Protesilaos Stavrou
2023-02-17 10:31 ` Robert Pluim
2023-02-17 10:40 ` Protesilaos Stavrou
2023-02-17 10:58 ` Robert Pluim
2023-02-17 11:33 ` Protesilaos Stavrou
2023-02-17 12:30 ` Robert Pluim
2023-02-17 12:35 ` Eli Zaretskii
2023-02-17 12:43 ` Robert Pluim
2023-02-18 7:36 ` Protesilaos Stavrou
2023-02-17 12:02 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-17 15:47 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1ow23wz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61567@debbugs.gnu.org \
--cc=info@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).