From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61624: 30.0.50; [PATCH] More doc on image-dired-dired-* Date: Sun, 19 Feb 2023 14:05:07 +0200 Message-ID: <83y1otx3m4.fsf@gnu.org> References: <87edqlsx6y.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28467"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61624@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 19 13:06:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTiSQ-0007EG-5b for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Feb 2023 13:06:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTiSF-0000tH-Kq; Sun, 19 Feb 2023 07:06:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTiSA-0000s5-E9 for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 07:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTiSA-0006HO-5K for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 07:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTiSA-0001wC-14 for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 07:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Feb 2023 12:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61624-submit@debbugs.gnu.org id=B61624.16768083117345 (code B ref 61624); Sun, 19 Feb 2023 12:06:01 +0000 Original-Received: (at 61624) by debbugs.gnu.org; 19 Feb 2023 12:05:11 +0000 Original-Received: from localhost ([127.0.0.1]:45864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTiRK-0001uO-Jw for submit@debbugs.gnu.org; Sun, 19 Feb 2023 07:05:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTiRJ-0001u9-4k for 61624@debbugs.gnu.org; Sun, 19 Feb 2023 07:05:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTiRD-0005kQ-Ci; Sun, 19 Feb 2023 07:05:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZGVJRM+xduCmz5+GAhlth8iSxKjyjgEhTLhaHKYnN5s=; b=kTuZt1CSGDrV 0867NMzThfa+lYBaVFtl+7dpYPGWbgD6ClT5TemtAtag9DEG+I3E7HjvCkuQ8eTJlcp0Hn2sWWMSV MamTQWWbrw4rUvavRs8LdHJlAkrIoMyL67WHj7IFgE8gJwxmgjG83xQzsFhkksm4Z7B1nDdRiHlQW fz9XEg/JHvHENZ2cWG2yRlQuHlectU/OQpHow3z2tEbpVuBv7X03u+Gf1qTOyd6WhPSgDWr0OiywZ h2dI2KZB/B1O+RFd5v1ojZ72k1Bb7j8cypQsAzYLGkLjXgJFwT8F8711hj8g9V9qtISk0vRiONp81 wamk3CFf/hTT0kSby3Au4Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTiRC-0005EW-Cj; Sun, 19 Feb 2023 07:05:02 -0500 In-Reply-To: <87edqlsx6y.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256055 Archived-At: > Date: Sun, 19 Feb 2023 12:37:25 +0100 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Here is more documentation on some image-dired-dired-* commands. Thanks. I have a few comments: > * doc/emacs/dired.texi (Image-Dired): Some fix and more documentation > about image-dired-dired-* commands. ^^^ "fixes", I guess? > @findex image-dired-display-previous > With point in the thumbnail buffer, you can type @key{RET} > (@code{image-dired-display-this}) to display the image in another > -window. Use the arrow keys to move around in the thumbnail buffer. > -For easy browsing, use @key{SPC} (@code{image-dired-display-next}) to > -advance and display the next image. Typing @key{DEL} > -(@code{image-dired-display-previous}) backs up to the previous > -thumbnail and displays that instead. > +window. Use the standard Emacs movement shortcuts or the arrow keys ^^^^^^^^^ We say "key bindings" not "shortcuts". > You can delete images through Image-Dired also. Type @kbd{d} > (@code{image-dired-flag-thumb-original-file}) to flag the image file > -for deletion in the Dired buffer. You can also delete the thumbnail > +for deletion in the Dired buffer. You can also remove the thumbnail > image from the thumbnail buffer with @kbd{C-d} > (@code{image-dired-delete-char}). Not sure I understand the reason for this. "Deletion" goes together with "delete", so why use "remove" instead? > +@findex image-dired-dired-toggle-marked-thumbs > +@findex image-dired-dired-display-external > +@findex image-dired-dired-display-image > + You could also use Image-Dired for @dfn{inline} operations (i.e., ^^^^^^^^^^^^^^^^^^^^^^^ As a general rule, whenever you use @dfn to introduce new terminology, you should have a suitable @cindex entry, so that readers could easily find the description of the term if they see it later in the manual. > +right into the Dired buffer). Type @kbd{C-t C-t} and the thumbnails ^ Comma is missing there. > +(@code{image-dired-dired-toggle-marked-thumbs}). @kbd{C-t i} and > +@kbd{C-t x} will display the image under the point into Emacs or with > +the external viewer, respectively. "Display the image ... into Emacs" sounds awkward. I'd say "in Emacs" instead. > -@kbd{C-t t} (@code{image-dired-tag-files}). This reads the tag name > +@kbd{C- tt} (@code{image-dired-tag-files}). This reads the tag name ^^^^^ Is that a typo? > +@findex image-dired-dired-comment-files > +@findex image-dired-dired-edit-comment-and-tags > You can also tag a file directly from the thumbnail buffer by typing > @kbd{t t} and you can remove a tag by typing @kbd{t r}. There is also ^ A comma missing there. > -a special tag called ``comment'' for each file (it is not a tag in > -the exact same sense as the other tags, it is handled slightly > -differently). That is used to enter a comment or description about the > -image. You comment a file from the thumbnail buffer by typing > +a special tag called ``comment'' for each file (it is not a tag in the > +exact same sense as the other tags, it is handled slightly > +differently). That is used to enter a comment or description about > +the image. You comment a file from the thumbnail buffer by typing Is this part just a refill of the same text?