From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65359: [PATCH] eglot: add "lexical" LSP server Date: Sat, 19 Aug 2023 11:38:26 +0300 Message-ID: <83y1i7zat9.fsf@gnu.org> References: <83pm3k51r1.fsf@gnu.org> <770EF5AF-61C7-4974-8A5E-0CA7851C3FBE@outlook.com> <83fs4g4zwv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17333"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65359@debbugs.gnu.org To: Mou Tong , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 19 10:39:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXHUI-0004JA-OX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Aug 2023 10:39:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXHU6-00087Q-R6; Sat, 19 Aug 2023 04:39:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXHU5-00086z-4O for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 04:39:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXHU4-0007yk-Sq for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 04:39:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXHU5-0004zW-LJ for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 04:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 08:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65359 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65359-submit@debbugs.gnu.org id=B65359.169243430419121 (code B ref 65359); Sat, 19 Aug 2023 08:39:01 +0000 Original-Received: (at 65359) by debbugs.gnu.org; 19 Aug 2023 08:38:24 +0000 Original-Received: from localhost ([127.0.0.1]:49375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXHTT-0004yK-S7 for submit@debbugs.gnu.org; Sat, 19 Aug 2023 04:38:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXHTS-0004y5-6H for 65359@debbugs.gnu.org; Sat, 19 Aug 2023 04:38:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXHTL-0007vQ-Lo; Sat, 19 Aug 2023 04:38:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=uSc5GEkNVdTyTXgCTteNxIWqPgPDAmkdQjGy+sedaG0=; b=h/YA9QDWdfgUIXDxhIIN xZ+96tjUjLYdui4P3mC+A/medLqms1FbfV8ca1MdJvmvw3E6S3IbkK04P5YLtz5keCQY+x1xKPaMO oALVTQEXvekSYxTlCIlUdrTGBXkQPlqaF/nNKS2KpLa5RwsPm4Y9u04mg0VuCqfZx4ZU+h6KkQ+5e 3ZiaFUsA71Ngw6EjngcDDhzRt/I+XlBoRSM561kKACeEyeCwU7itJwWOgTy+NlOHRqFi0smz54Gwq rinLyrlATKeX0q8agvG2rACYzBH3McvXR9jJfOQ9mEBtDvlDR6rT27Zt69mSBttXXSiaGTomEJjUw Vlh3CwaGYBeoyg==; In-Reply-To: (message from Mou Tong on Fri, 18 Aug 2023 07:08:42 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267831 Archived-At: > From: Mou Tong > CC: "65359@debbugs.gnu.org" <65359@debbugs.gnu.org> > Date: Fri, 18 Aug 2023 07:08:42 +0000 > > Eli Zaretskii writes: > > > Then we should make this entry be in effect only on systems that > > aren't Windows. > > > > I don't mind installing this now, but only if it doesn't break Elixir > > support on Windows, which would mean this new entry should be hidden > > when Emacs runs on Windows. > > Oh, I see, here is the new patch, I'm using the `eglot-alternatives` > in the else so we don't see lexical on Windows. > > > I also don't mind waiting... > > Actually I'd like it got merged so I needn't to keep the hack in my > configuration. (Forgive me laziness...) Joćo, is the below OK with you? It's for the master branch. > From 18161aea6287ffd177834fdac156f6037c410856 Mon Sep 17 00:00:00 2001 > From: dalu > Date: Thu, 17 Aug 2023 18:34:42 +0800 > Subject: [PATCH] Add "lexical" LSP server to Eglot > > lexical does not support Windows currently > --- > lisp/progmodes/eglot.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index 113ff08e94e..65daa0941d5 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -222,7 +222,8 @@ eglot-server-programs > . ,(if (and (fboundp 'w32-shell-dos-semantics) > (w32-shell-dos-semantics)) > '("language_server.bat") > - '("language_server.sh"))) > + (eglot-alternatives > + '("language_server.sh" "start_lexical.sh")))) > (ada-mode . ("ada_language_server")) > (scala-mode . ,(eglot-alternatives > '("metals" "metals-emacs"))) > -- > 2.41.0 >