From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work Date: Tue, 24 Oct 2023 15:14:24 +0300 Message-ID: <83y1fskyjj.fsf@gnu.org> References: <1d9187b71e7288eaf08ac9a2f0559bdf@gmail.com> <8334y4s0oe.fsf@gnu.org> <83v8axmbsh.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11592"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 24 14:15:01 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvGJI-0002q4-To for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Oct 2023 14:15:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvGIt-0001H3-EX; Tue, 24 Oct 2023 08:14:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvGIr-0001Gh-Nc for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 08:14:33 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qvGIr-0003kR-Fa for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 08:14:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qvGJK-0003Jr-IH for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 08:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Oct 2023 12:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66655 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 66655-submit@debbugs.gnu.org id=B66655.169814969912734 (code B ref 66655); Tue, 24 Oct 2023 12:15:02 +0000 Original-Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 12:14:59 +0000 Original-Received: from localhost ([127.0.0.1]:53363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvGJH-0003JJ-1K for submit@debbugs.gnu.org; Tue, 24 Oct 2023 08:14:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvGJD-0003J2-Cn for 66655@debbugs.gnu.org; Tue, 24 Oct 2023 08:14:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvGIe-0003ix-Ca; Tue, 24 Oct 2023 08:14:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=d+4NU+1f420TS+XI9EAttHnf2mDO+PzNPM4Y3syXqUI=; b=CaJTsfm1eLrC sSr5ri3KoWxDjkt1aitYZ1f/+sbRXgb5P4VIyjmZperky/UvDDiizEmNt0vZOnnaDXbVKx4jnavo0 5Ke434kLoTzT2U/PEAM4xDHLb4/pBIAJy7kChChDj3DeFynQzRf8ItUi5N1C8l87Daf6C9PIjSror BcDr45cB1EBRWVIfBsmw3cnPzMq6pVvQMULpX3NsTTjQaRLv/926hJH9yhPESknqRsBWkO3EijP68 HamWxtWqIxYw4tTNxLaTq/rqj5qb3NHzuaI+33q3VRbib9dboifCGqz4jvj/CpNrXNXS4fbKn48Li 9+o0nrobUpjVKu3KZ9Hxrw==; In-Reply-To: (message from Stefan Monnier on Mon, 23 Oct 2023 18:36:11 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273099 Archived-At: > From: Stefan Monnier > Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org > Date: Mon, 23 Oct 2023 18:36:11 -0400 > > > Yes, that's the logic here. Technically, it happens because clicking > > the mouse emits 2 events: down-mouse-1 followed by another one caused > > by releasing the mouse button, and the first event could cause > > redisplay (as happens in this case) because it generally moves point > > to the location of the click. > > So maybe, in order to upgrade an `up` to a `drag` we should check that: > - the end (buffer) position is different. > - and the mouse has actually moved. How do you do the latter in a way that still supports arbitrary values in double-click-fuzz? > Currently we detect a mouse-has-moved when the start and end (screen) > position of the mouse are different, but maybe we should additionally > set a flag when the mouse is moved, so that it's still considered as > "moved" if the mouse returns to its initial (screen) position? What will that do if the mouse was moved, then returned to the original position before the button is released?