From: Eli Zaretskii <eliz@gnu.org>
To: Denis Zubarev <dvzubarev@yandex.ru>, Yuan Fu <casouri@gmail.com>
Cc: 67117@debbugs.gnu.org
Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward
Date: Wed, 15 Nov 2023 15:21:59 +0200 [thread overview]
Message-ID: <83y1ezqhhk.fsf@gnu.org> (raw)
In-Reply-To: <87h6lruah2.fsf@yandex.ru> (message from Denis Zubarev on Sun, 12 Nov 2023 02:38:33 +0300)
> From: Denis Zubarev <dvzubarev@yandex.ru>
> Date: Sun, 12 Nov 2023 02:38:33 +0300
>
> Steps to reproduce the issue:
> 1. emacs -Q
> 2. M-x find-file /tmp/t.py
> 3. paste to the buffer
>
> Temp(1, 2)
>
> 4. M-x python-ts-mode
> 5. Call search-subtree with backward flag
> M-x eval-expression (treesit-search-subtree
> (treesit--thing-at (point) "call")
> (lambda (n) (equal (treesit-node-type n ) "integer"))
> t)
> It should return the second int node (#<treesit-node integer in 9-10>), but it returns nil.
Yuan, any comments to the patch and the issue in general?
Denis, your changes are too large for us to accept them without a
copyright assignment. Would you like to start your assignment
paperwork at this time, so that we could accept this contribution, and
all your future ones?
Thanks.
next prev parent reply other threads:[~2023-11-15 13:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 23:38 bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Denis Zubarev
2023-11-15 13:21 ` Eli Zaretskii [this message]
2023-11-15 17:01 ` Eli Zaretskii
2023-11-18 18:47 ` Yuan Fu
2023-11-19 5:47 ` Eli Zaretskii
2023-11-19 6:13 ` Yuan Fu
2023-11-19 6:40 ` Eli Zaretskii
2023-11-21 4:23 ` Yuan Fu
2023-11-21 11:43 ` Eli Zaretskii
2023-11-25 3:44 ` Yuan Fu
2023-11-19 9:15 ` Eli Zaretskii
2023-11-19 11:25 ` Denis Zubarev
2023-11-19 11:45 ` Eli Zaretskii
2023-12-19 0:24 ` Denis Zubarev
2023-12-19 2:26 ` Yuan Fu
2023-12-19 16:52 ` Eli Zaretskii
2023-12-19 17:08 ` Denis Zubarev
2023-12-23 7:09 ` Yuan Fu
2023-12-26 0:39 ` Yuan Fu
2023-12-19 3:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1ezqhhk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67117@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dvzubarev@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).