From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55871: Acknowledgement (27.1; vc-git.el log view 'a', 'f', 'd' do not work when following renames) Date: Fri, 15 Dec 2023 15:05:04 +0200 Message-ID: <83y1dvobun.fsf@gnu.org> References: <78f97339-2aca-0dbd-4cb4-3532af78a895@yandex.ru> <1b16a642-8a85-e693-66fc-41c37df24908@yandex.ru> <36b48587-a723-73ae-fefb-886d69d04ec8@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30102"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55871@debbugs.gnu.org, n.oje.bar@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 15 14:06:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rE7tU-0007dQ-Gz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Dec 2023 14:06:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rE7tF-0005IW-7l; Fri, 15 Dec 2023 08:06:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rE7tD-0005IO-CN for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2023 08:06:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rE7tC-0000NW-BS for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2023 08:06:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rE7tC-0000k1-2E for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2023 08:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Dec 2023 13:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55871-submit@debbugs.gnu.org id=B55871.17026455122792 (code B ref 55871); Fri, 15 Dec 2023 13:06:02 +0000 Original-Received: (at 55871) by debbugs.gnu.org; 15 Dec 2023 13:05:12 +0000 Original-Received: from localhost ([127.0.0.1]:51750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rE7sO-0000ix-8L for submit@debbugs.gnu.org; Fri, 15 Dec 2023 08:05:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rE7sL-0000ij-V0 for 55871@debbugs.gnu.org; Fri, 15 Dec 2023 08:05:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rE7sG-0008Ui-4H; Fri, 15 Dec 2023 08:05:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=p92bzxue4LeuzCUaqsLez+edweyYEMoPBhkGhGzxpik=; b=V2qdjqfVUvK/ 0UPGuoaS6TCERfZFs+HwH6DZTipXLZz2UW5FgHBH9valVNNS+Bs9/5EYrtrevbxQduDIRK7aZ2Rri hpF73W8ZrGv0AKFqDn+GkHUDg0JOz3AHfghBfxw3aXhTzpjtRGZCI69fR79oYWddCT9QTIirqjSFI ecax6KL+EGNtMgiUwUGRuSrvffsYr7xnmSL+6FYpI3M1/3tAmInz/1qwTNWGDaDtqAvnJzR6E5xfb VD5+ej0jjLUd16fw6NwwHSGffAJUcQBjLVabw/oCzM47Vp0hBl7csA++qVQWBK/3TRhkLLunTHYev V5PnCdVqmtPqLYJE7x2KXQ==; In-Reply-To: <36b48587-a723-73ae-fefb-886d69d04ec8@yandex.ru> (message from Dmitry Gutov on Fri, 15 Dec 2023 04:01:59 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276263 Archived-At: > Cc: 55871@debbugs.gnu.org > Date: Fri, 15 Dec 2023 04:01:59 +0200 > From: Dmitry Gutov > > On 14/12/2023 03:23, Dmitry Gutov wrote: > > On 14/12/2023 02:52, Dmitry Gutov wrote: > >> but otherwise seems to function well (with potential for future > >> additions) > > > > To clarify: this version only makes 'd' work (not 'f' or 'a'), but the > > other two are fixed more easily. > > Attached is the new revision with combined fix. FYI: 'd' and 'f' work with bzr without any changes. 'a' doesn't work (evidently, "bzr annotate -r REVISION FILE" doesn't work when FILE did not exist in REVISION, but was renamed by a later revision, and one needs to run "bzr status -Sr REVISION" and look for the "renamed" report in the result, which will then provide the previous name). (FTR: I used src/unexcoff.c file to test this.) > +*** Support for viewing file change history across renames. > +When a fileset's VC change history ends at a rename, we now print the > +old name(s) and a button which jumps to their history. Only supported > +with Git at the moment. I think this should at least tell that for files under Bazaar, the VC change history will always include the renames. Looks like Mercurial is in the same department as Git? If so, I think the text should say that this is not supported for Mercurial yet, and that Bazaar shows the entire history, including renames, by default. Or something like that. I also think this entry should mention the relevant VC commands ("C-x v l" and what else?), since otherwise "VC change history" is not concrete enough to tell users which command(s) is/are affected. Thanks.