From: Eli Zaretskii <eliz@gnu.org>
To: Morgan Willcock <morgan@ice9.digital>
Cc: 68185@debbugs.gnu.org
Subject: bug#68185: [PATCH] Ensure indent-region argument order is correct
Date: Thu, 04 Jan 2024 13:22:56 +0200 [thread overview]
Message-ID: <83y1d5wdf3.fsf@gnu.org> (raw)
In-Reply-To: <87wmstnfxd.fsf@ice9.digital> (message from Morgan Willcock on Mon, 01 Jan 2024 17:04:30 +0000)
> From: Morgan Willcock <morgan@ice9.digital>
> Date: Mon, 01 Jan 2024 17:04:30 +0000
>
> Attached is a replacement patch which I believe fixes the issue with the
> region selection direction and with indentation potentially being
> incorrectly applied to text that is inserted by the template.
>
> Previously when text was being inserted at the region start it was
> actually going into region, which means that it will have been possible
> for template contents to have accidentally been indented along with the
> region that the user selected. I've changed the marker insertion type
> for the start boundary, which should preserve the original indentation
> of text which was inserted by the template, i.e. if text inserted by the
> template should be indented this is now back under control of the
> template rather than applied by accident.
>
> The changes do mean that the indentation of existing templates may
> change, but I think this will only be for templates which accidentally
> omitted the indentation directives because indentation was mistakenly
> applied as part of the region.
Thanks, installed (the additional part which wasn't in the previous
patch).
next prev parent reply other threads:[~2024-01-04 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-31 21:20 bug#68185: [PATCH] Ensure indent-region argument order is correct Morgan Willcock
2023-12-31 22:39 ` Morgan Willcock
2024-01-01 17:04 ` Morgan Willcock
2024-01-04 11:22 ` Eli Zaretskii [this message]
2024-01-04 11:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1d5wdf3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68185@debbugs.gnu.org \
--cc=morgan@ice9.digital \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).