* bug#6736: Windows: make maintainer-clean does not restore fully clean bzr tree
@ 2010-07-27 2:28 Christoph
2010-07-27 13:16 ` Jason Rumney
0 siblings, 1 reply; 9+ messages in thread
From: Christoph @ 2010-07-27 2:28 UTC (permalink / raw)
To: 6736
According to the documentation in nt/INSTALL, `make maintainer-clean' is
supposed to "Remove everything that can be recreated, including compiled
lisp files, to get back to the state of a fresh Bazaar tree."
Running `mingw32-make maintainer-clean' on Windows 7, GnuWin32 and MinGW
does not seem to do exactly that.
Per Juanma's suggestion I ran
bzr clean-tree --unknown --ignored --detritus --force
and it produced the following output:
deleting paths:
bin
site-lisp
admin/unidata/makefile
lisp/cedet/ede/loaddefs.el~
lisp/cedet/semantic/loaddefs.el~
lisp/cedet/srecode/loaddefs.el~
This was right after a `mingw32-make maintainer-clean'.
The bin/ directory still contained the following files: cmdproxy.exe
The site-lisp/ directory contained: subdirs.el
`make realclean' deletes ../bin eventually. Shouldn't `maintainer-clean'
do the same if it claims to restore the fresh tree checkout?
Christoph
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#6736: Windows: make maintainer-clean does not restore fully clean bzr tree
2010-07-27 2:28 bug#6736: Windows: make maintainer-clean does not restore fully clean bzr tree Christoph
@ 2010-07-27 13:16 ` Jason Rumney
2010-07-27 17:02 ` Eli Zaretskii
2010-08-02 1:39 ` Christoph
0 siblings, 2 replies; 9+ messages in thread
From: Jason Rumney @ 2010-07-27 13:16 UTC (permalink / raw)
To: Christoph; +Cc: 6736
Christoph <cschol2112@googlemail.com> writes:
> The bin/ directory still contained the following files: cmdproxy.exe
> The site-lisp/ directory contained: subdirs.el
>
> `make realclean' deletes ../bin eventually. Shouldn't
> maintainer-clean' do the same if it claims to restore the fresh tree
> checkout?
I'm not sure.
Anything in ../bin is put there by "make install". I'm pretty sure make
maintainer-clean doesn't uninstall installed executables on other platforms
either, but then those platforms will also have installed copies of
other things that maintainer-clean does delete. Also if cmdproxy.exe is
the only file left in ../bin, then that seems more like a buggy
oversight than deliberately leaving the installed files alone.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#6736: Windows: make maintainer-clean does not restore fully clean bzr tree
2010-07-27 13:16 ` Jason Rumney
@ 2010-07-27 17:02 ` Eli Zaretskii
2010-08-02 1:39 ` Christoph
1 sibling, 0 replies; 9+ messages in thread
From: Eli Zaretskii @ 2010-07-27 17:02 UTC (permalink / raw)
To: Jason Rumney; +Cc: cschol2112, 6736
> From: Jason Rumney <jasonr@gnu.org>
> Date: Tue, 27 Jul 2010 21:16:00 +0800
> Cc: 6736@debbugs.gnu.org
>
> Christoph <cschol2112@googlemail.com> writes:
>
> > The bin/ directory still contained the following files: cmdproxy.exe
> > The site-lisp/ directory contained: subdirs.el
> >
> > `make realclean' deletes ../bin eventually. Shouldn't
> > maintainer-clean' do the same if it claims to restore the fresh tree
> > checkout?
>
> I'm not sure.
>
> Anything in ../bin is put there by "make install". I'm pretty sure make
> maintainer-clean doesn't uninstall installed executables on other platforms
> either, but then those platforms will also have installed copies of
> other things that maintainer-clean does delete. Also if cmdproxy.exe is
> the only file left in ../bin, then that seems more like a buggy
> oversight than deliberately leaving the installed files alone.
I agree with Jason, FWIW.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#6736: Windows: make maintainer-clean does not restore fully clean bzr tree
2010-07-27 13:16 ` Jason Rumney
2010-07-27 17:02 ` Eli Zaretskii
@ 2010-08-02 1:39 ` Christoph
2010-08-02 2:42 ` Juanma Barranquero
1 sibling, 1 reply; 9+ messages in thread
From: Christoph @ 2010-08-02 1:39 UTC (permalink / raw)
To: Jason Rumney; +Cc: 6736
On 7/27/2010 7:16 AM, Jason Rumney wrote:
> Anything in ../bin is put there by "make install".
Actually, cmdproxy.exe is copied to bin by `make bootstrap', since
(according to a comment in the makefile) it needs it during the
bootstrap process.
> I'm pretty sure make
> maintainer-clean doesn't uninstall installed executables on other platforms
> either, but then those platforms will also have installed copies of
> other things that maintainer-clean does delete. Also if cmdproxy.exe is
> the only file left in ../bin, then that seems more like a buggy
> oversight than deliberately leaving the installed files alone.
OK. What about the site-lisp directory? Is it safe to delete it too or
could the user have files in it that he does not want to loose?
Christoph
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#6736: Windows: make maintainer-clean does not restore fully clean bzr tree
2010-08-02 1:39 ` Christoph
@ 2010-08-02 2:42 ` Juanma Barranquero
2010-08-02 3:58 ` Christoph
0 siblings, 1 reply; 9+ messages in thread
From: Juanma Barranquero @ 2010-08-02 2:42 UTC (permalink / raw)
To: Christoph; +Cc: 6736
On Mon, Aug 2, 2010 at 03:39, Christoph <cschol2112@googlemail.com> wrote:
> OK. What about the site-lisp directory? Is it safe to delete it too or could
> the user have files in it that he does not want to loose?
Isn't that the whole point of site-lisp?
Juanma
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#6736: Windows: make maintainer-clean does not restore fully clean bzr tree
2010-08-02 2:42 ` Juanma Barranquero
@ 2010-08-02 3:58 ` Christoph
2010-08-02 4:10 ` Juanma Barranquero
0 siblings, 1 reply; 9+ messages in thread
From: Christoph @ 2010-08-02 3:58 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: 6736
On 8/1/2010 8:42 PM, Juanma Barranquero wrote:
>> OK. What about the site-lisp directory? Is it safe to delete it too or could
>> the user have files in it that he does not want to loose?
>
> Isn't that the whole point of site-lisp?
Right. I guess I will rephrase the question: is there ever a situation
where we SHOULD delete the site-lisp directory, specifically with `make
maintainer-clean'?
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#6736: Windows: make maintainer-clean does not restore fully clean bzr tree
2010-08-02 3:58 ` Christoph
@ 2010-08-02 4:10 ` Juanma Barranquero
2016-12-07 3:57 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: Juanma Barranquero @ 2010-08-02 4:10 UTC (permalink / raw)
To: Christoph; +Cc: 6736
On Mon, Aug 2, 2010 at 05:58, Christoph <cschol2112@googlemail.com> wrote:
> Right. I guess I will rephrase the question: is there ever a situation where
> we SHOULD delete the site-lisp directory, specifically with `make
> maintainer-clean'?
Should? I don't think so. Could? If you can determine that it has
nothing of value. But I don't think it's worth the trouble.
Juanma
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-12-07 16:02 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-27 2:28 bug#6736: Windows: make maintainer-clean does not restore fully clean bzr tree Christoph
2010-07-27 13:16 ` Jason Rumney
2010-07-27 17:02 ` Eli Zaretskii
2010-08-02 1:39 ` Christoph
2010-08-02 2:42 ` Juanma Barranquero
2010-08-02 3:58 ` Christoph
2010-08-02 4:10 ` Juanma Barranquero
2016-12-07 3:57 ` Glenn Morris
2016-12-07 16:02 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).