From: Eli Zaretskii <eliz@gnu.org>
To: Ari Roponen <ari.roponen@gmail.com>
Cc: 11464@debbugs.gnu.org
Subject: bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text
Date: Tue, 15 May 2012 19:19:52 +0300 [thread overview]
Message-ID: <83wr4do1qv.fsf@gnu.org> (raw)
In-Reply-To: <87fwb1dagj.fsf_-_@gmail.com>
> From: Ari Roponen <ari.roponen@gmail.com>
> Cc: 11464@debbugs.gnu.org
> Date: Tue, 15 May 2012 13:07:08 +0300
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >
> > But since the fix is quite simple, here you go: fixed in revision
> > 107994 on the emacs-24 branch.
> >
>
> Thank you. I can still reproduce the bug with that revision, but the
> following tweak seems to help. I'm not sure if it is correct, but at
> least it fixes the testcase, and everything else seems to work okay.
>
> === modified file 'src/xdisp.c'
> --- src/xdisp.c 2012-05-13 18:22:35 +0000
> +++ src/xdisp.c 2012-05-15 09:51:45 +0000
> @@ -1313,7 +1313,7 @@
> visible_p = bottom_y > window_top_y;
> else if (top_y < it.last_visible_y)
> visible_p = 1;
> - if (bottom_y >= it.last_visible_y
> + if (bottom_y <= it.last_visible_y
> && it.bidi_p && it.bidi_it.scan_dir == -1
> && IT_CHARPOS (it) < charpos)
> {
Interesting. What are the values of bottom_y and it.last_visible_y
that you see? I only see strict equality in that condition, so both
variants work for me.
Anyway, I installed the change you suggested, thanks.
next prev parent reply other threads:[~2012-05-15 16:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 15:54 bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text Ari Roponen
2012-05-13 18:26 ` Eli Zaretskii
2012-05-15 10:07 ` Ari Roponen
2012-05-15 16:19 ` Eli Zaretskii [this message]
2012-05-16 5:21 ` Ari Roponen
2012-05-16 15:15 ` Eli Zaretskii
2012-05-17 4:52 ` Ari Roponen
2012-05-17 16:23 ` Eli Zaretskii
2012-05-17 17:54 ` Ari Roponen
2012-05-17 17:56 ` Michael Welsh Duggan
2012-05-17 21:11 ` Eli Zaretskii
2012-05-17 21:22 ` Michael Welsh Duggan
2012-05-18 7:42 ` Eli Zaretskii
2012-05-18 8:03 ` Ari Roponen
2012-05-18 8:26 ` Ari Roponen
2012-05-18 8:44 ` Eli Zaretskii
2012-05-18 10:47 ` Ari Roponen
2012-05-18 11:32 ` Eli Zaretskii
2012-05-18 11:47 ` Ari Roponen
2012-05-18 14:02 ` Eli Zaretskii
2012-05-18 14:39 ` Ari Roponen
2012-05-18 14:59 ` Eli Zaretskii
2012-05-19 12:26 ` Eli Zaretskii
2012-05-19 12:32 ` Ari Roponen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wr4do1qv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=11464@debbugs.gnu.org \
--cc=ari.roponen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).