bug#12306: etags crashes

bug#12306: etags crashes

[Viking Rollo]

etags crashes (probably) on objective-c.
recipe on cmd.exe
 >svn co svn://svn.gna.org/svn/gnustep/trunk gnustep

>cd gnustep
>find . -iname "*.[mh]" -print | c:\EMACS\NTEmacs\bin\etags.exe -

etags also crashes on cocotron source. (hg clone http://cocotron.googlecode.com/hg/ cocotron)
I found this on NTEmacs but etags also crashes on Mac OS X. (Segmentation fault: 11)


C:\>c:\EMACS\NTEmacs\bin\etags.exe --version
etags (GNU Emacs 24.2.50)
Copyright (C) 2012 Free Software Foundation, Inc.
This program is distributed under the terms in ETAGS.README


In GNU Emacs 24.2.50.1 (i386-mingw-nt6.1.7601)
  of 2012-08-29 on OZ-VAIO
Bzr revision: 109809 
monnier@iro.umontreal.ca-20120828201421-l3s8f0ox5eablvi8
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
  `configure --with-gcc (3.4)'

In GNU Emacs 24.2.50.1 (x86_64-apple-darwin11.4.0, NS apple-appkit-1138.47)
of 2012-08-29 on uf265202.local
Bzr revision: 109809monnier@iro.umontreal.ca-20120828201421-l3s8f0ox5eablvi8
Windowing system distributor `Apple', version 10.3.1138
Configured using:
`configure '--with-ns''

bug#12306: etags crashes

[Glenn Morris]

Viking Rollo wrote:

>>svn co svn://svn.gna.org/svn/gnustep/trunk gnustep
>
>>cd gnustep
>>find . -iname "*.[mh]" -print | c:\EMACS\NTEmacs\bin\etags.exe -

Works fine for me on x86_64 GNU/Linux.

bug#12306: etags crashes

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Wed, 29 Aug 2012 22:01:34 -0400
> Cc: 12306@debbugs.gnu.org
> 
> Viking Rollo wrote:
> 
> >>svn co svn://svn.gna.org/svn/gnustep/trunk gnustep
> >
> >>cd gnustep
> >>find . -iname "*.[mh]" -print | c:\EMACS\NTEmacs\bin\etags.exe -
> 
> Works fine for me on x86_64 GNU/Linux.

Crashes for me on x86_64 GNU/Linux:

  Program received signal SIGSEGV, Segmentation fault.
  0x00007ffff7ae06d1 in mempcpy () from /lib/libc.so.6
  (gdb) bt
  #0  0x00007ffff7ae06d1 in mempcpy () from /lib/libc.so.6
  #1  0x00007ffff7acd197 in _IO_file_xsputn () from /lib/libc.so.6
  #2  0x00007ffff7ac2b0c in fputs () from /lib/libc.so.6
  #3  0x0000000000403654 in put_entries (np=0x647410)
      at /home/e/eliz/bzr/emacs/trunk/lib-src/etags.c:2190
  #4  0x0000000000402b81 in process_file (fh=0x63cf20,
      fn=0x647640 "./modules/dev-libs/gscoredata/DataBuilder/Document.m",
      lang=0x0) at /home/e/eliz/bzr/emacs/trunk/lib-src/etags.c:1673
  #5  0x0000000000402918 in process_file_name (
      file=0x623280 "./modules/dev-libs/gscoredata/DataBuilder/Document.m",
      lang=0x0) at /home/e/eliz/bzr/emacs/trunk/lib-src/etags.c:1597
  #6  0x0000000000402180 in main (argc=2, argv=0x7fffffffe5b8)
      at /home/e/eliz/bzr/emacs/trunk/lib-src/etags.c:1273
  (gdb) frame 3
  #3  0x0000000000403654 in put_entries (np=0x647410)
      at /home/e/eliz/bzr/emacs/trunk/lib-src/etags.c:2190
  2190              fputs (np->regex, tagf);
  (gdb) l
  2185                  fdp = np->fdp;
  2186                  fprintf (tagf, "\f\n%s,%d\n",
  2187                           fdp->taggedfname, total_size_of_entries (np));
  2188                  fdp->written = TRUE;
  2189                }
  2190              fputs (np->regex, tagf);
  2191              fputc ('\177', tagf);
  2192              if (np->name != NULL)
  2193                {
  2194                  fputs (np->name, tagf);
  (gdb) p np->regex
  $1 = 0x647d30 "  * const ConfigurationsDidChangeNotification "
  (gdb) p *np
  $2 = {left = 0x0, right = 0x6473a0, fdp = 0x646d70, name = 0x0,
    regex = 0x647d30 "  * const ConfigurationsDidChangeNotification ",
    valid = 1, is_func = 0, been_warned = 0, lno = 39, cno = 1134}

Not sure why it crashes (stack smashed?).

bug#12306: etags crashes

[Andreas Schwab]

Fixed.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."