From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12697: Emacs crashes when using it as the commit editor for git Date: Sat, 27 Oct 2012 09:52:11 +0200 Message-ID: <83wqyc8i8k.fsf@gnu.org> References: <508B71A9.40509@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1351324373 26192 80.91.229.3 (27 Oct 2012 07:52:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Oct 2012 07:52:53 +0000 (UTC) Cc: matthew@mattleach.net, 12697@debbugs.gnu.org, schwab@linux-m68k.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 27 09:53:01 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TS1CX-0004uo-7N for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Oct 2012 09:53:01 +0200 Original-Received: from localhost ([::1]:33102 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TS1CP-0007oh-7o for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Oct 2012 03:52:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TS1CN-0007oc-7u for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2012 03:52:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TS1CM-0007uW-6n for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2012 03:52:51 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TS1CM-0007uS-3Y for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2012 03:52:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TS1EU-00055Y-DR for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2012 03:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Oct 2012 07:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12697 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12697-submit@debbugs.gnu.org id=B12697.135132449119544 (code B ref 12697); Sat, 27 Oct 2012 07:55:02 +0000 Original-Received: (at 12697) by debbugs.gnu.org; 27 Oct 2012 07:54:51 +0000 Original-Received: from localhost ([127.0.0.1]:35448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TS1EJ-00055A-HY for submit@debbugs.gnu.org; Sat, 27 Oct 2012 03:54:51 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:47882) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TS1EH-000551-49 for 12697@debbugs.gnu.org; Sat, 27 Oct 2012 03:54:50 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MCJ00700K8OUT00@a-mtaout21.012.net.il> for 12697@debbugs.gnu.org; Sat, 27 Oct 2012 09:52:08 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MCJ007G7KIVMWA0@a-mtaout21.012.net.il>; Sat, 27 Oct 2012 09:52:08 +0200 (IST) In-reply-to: <508B71A9.40509@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66100 Archived-At: > Date: Fri, 26 Oct 2012 22:31:21 -0700 > From: Paul Eggert > CC: Andreas Schwab , Eli Zaretskii , > Matthew Leach > > Instead, how about the attached patch? It reenables > the BSD_PGRPS idea, although reimplemented, as the old > code can't easily be resurrected as-is. I haven't > thought about how this affects the Windows port The termios-related stuff (the call to tcsetgrp) in sysdep.c should be #ifedf'ed away for Windows (for DOS_NT, actually). Also, the references to SIGTTOU should be conditioned on that signal being defined. Other than that, this should be OK, I think, since, if setpgid is not available, it is redirected to setpgrp, which already has a no-op implementation for Windows.