unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: matthew@mattleach.net, 12697@debbugs.gnu.org, schwab@linux-m68k.org
Subject: bug#12697: Emacs crashes when using it as the commit editor for git
Date: Sat, 27 Oct 2012 09:52:11 +0200	[thread overview]
Message-ID: <83wqyc8i8k.fsf@gnu.org> (raw)
In-Reply-To: <508B71A9.40509@cs.ucla.edu>

> Date: Fri, 26 Oct 2012 22:31:21 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: Andreas Schwab <schwab@linux-m68k.org>, Eli Zaretskii <eliz@gnu.org>, 
>  Matthew Leach <matthew@mattleach.net>
> 
> Instead, how about the attached patch?  It reenables
> the BSD_PGRPS idea, although reimplemented, as the old
> code can't easily be resurrected as-is.  I haven't
> thought about how this affects the Windows port

The termios-related stuff (the call to tcsetgrp) in sysdep.c should be
#ifedf'ed away for Windows (for DOS_NT, actually).  Also, the
references to SIGTTOU should be conditioned on that signal being
defined.

Other than that, this should be OK, I think, since, if setpgid is not
available, it is redirected to setpgrp, which already has a no-op
implementation for Windows.





  reply	other threads:[~2012-10-27  7:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-21 20:17 bug#12697: 24.2; Emacs crashes when using it as the commit editor for git Matthew Leach
2012-10-22  8:26 ` Andreas Schwab
2012-10-22 17:15   ` Eli Zaretskii
2012-10-22 17:39     ` Andreas Schwab
2012-10-22 20:22       ` Eli Zaretskii
2012-10-22 21:34         ` Andreas Schwab
2012-10-27  5:31 ` bug#12697: " Paul Eggert
2012-10-27  7:52   ` Eli Zaretskii [this message]
2012-10-28 18:57     ` Paul Eggert
2012-10-31 17:28 ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wqyc8i8k.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=12697@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=matthew@mattleach.net \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).