unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: eggert@cs.ucla.edu, 18410@debbugs.gnu.org
Subject: bug#18410: Use SAFE_ALLOCA etc. to avoid unbounded stack allocation.
Date: Mon, 08 Sep 2014 05:35:28 +0300	[thread overview]
Message-ID: <83wq9ec00f.fsf@gnu.org> (raw)
In-Reply-To: <jwvha0ikg41.fsf-monnier+emacsbugs@gnu.org>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>,  18410@debbugs.gnu.org
> Date: Sun, 07 Sep 2014 22:22:23 -0400
> 
> > Usually MAX_ALLOCA-related code falls back on malloc, and does not exit
> > merely because a request was larger.  callproc.c's child_setup function is
> 
> MAX_ALLOCA is chosen small so that we can allocate several/many objects
> of size MAX_ALLOCA.  Whereas in this case, after this alloca we're not
> expected to use up the stack much more (we're about to `exec' anyway,
> right?).  So MAX_ALLOCA is much too conservative for this case.

Indeed, I agree.  So I think we should increase the limit in
callproc.c, especially if we are going to keep the exit with failed
status when the limit is exceeded.





  reply	other threads:[~2014-09-08  2:35 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05  6:08 bug#18410: Use SAFE_ALLOCA etc. to avoid unbounded stack allocation Paul Eggert
2014-09-05  8:45 ` Dmitry Antipov
2014-09-05 15:01   ` Paul Eggert
2014-09-05 15:44   ` Stefan Monnier
2014-09-05 16:04     ` Andreas Schwab
2014-09-05 17:22       ` Stefan Monnier
2014-09-05  8:59 ` Dmitry Antipov
2014-09-05 15:03   ` Paul Eggert
2014-09-07  7:20 ` Paul Eggert
2014-09-07 17:09   ` Eli Zaretskii
2014-09-07 20:33     ` Paul Eggert
2014-09-08  2:22       ` Stefan Monnier
2014-09-08  2:35         ` Eli Zaretskii [this message]
2014-09-08  2:43           ` Stefan Monnier
2014-09-08  2:38         ` Paul Eggert
2014-09-08  3:17           ` Demetrios Obenour
2014-09-08  3:19             ` Daniel Colascione
2014-09-08  3:20               ` Demetrios Obenour
2014-09-08  7:26           ` Dmitry Antipov
2014-09-08  2:36       ` Eli Zaretskii
2014-09-08 12:48         ` Stefan Monnier
2014-09-09 13:17           ` Eli Zaretskii
2014-09-09 13:49             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wq9ec00f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=18410@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).