From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18545: 24.4.50: Bug - forward-line inside with-selected-window Date: Fri, 26 Sep 2014 10:31:18 +0300 Message-ID: <83wq8qu9bt.fsf@gnu.org> References: <1532440199.73121411675536923.JavaMail.www@wwinf7125> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1411716751 27874 80.91.229.3 (26 Sep 2014 07:32:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 26 Sep 2014 07:32:31 +0000 (UTC) Cc: 18545@debbugs.gnu.org To: lompik@voila.fr Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 26 09:32:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XXQ0q-0003ij-Fi for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Sep 2014 09:32:20 +0200 Original-Received: from localhost ([::1]:45148 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXQ0q-0006HN-29 for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Sep 2014 03:32:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXQ0i-0006HC-IT for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 03:32:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXQ0d-0002Ja-IS for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 03:32:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXQ0d-0002Au-FL for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 03:32:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XXQ0X-0005GM-TB for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 03:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Sep 2014 07:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18545 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18545-submit@debbugs.gnu.org id=B18545.141171668820186 (code B ref 18545); Fri, 26 Sep 2014 07:32:01 +0000 Original-Received: (at 18545) by debbugs.gnu.org; 26 Sep 2014 07:31:28 +0000 Original-Received: from localhost ([127.0.0.1]:52546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XXPzw-0005FT-49 for submit@debbugs.gnu.org; Fri, 26 Sep 2014 03:31:27 -0400 Original-Received: from mtaout26.012.net.il ([80.179.55.182]:44839) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XXPzq-0005FF-Pa for 18545@debbugs.gnu.org; Fri, 26 Sep 2014 03:31:22 -0400 Original-Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NCH00F00YUZ0K00@mtaout26.012.net.il> for 18545@debbugs.gnu.org; Fri, 26 Sep 2014 10:29:21 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NCH00DC5ZGXNI30@mtaout26.012.net.il>; Fri, 26 Sep 2014 10:29:21 +0300 (IDT) In-reply-to: <1532440199.73121411675536923.JavaMail.www@wwinf7125> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93762 Archived-At: > Date: Thu, 25 Sep 2014 22:05:36 +0200 (CEST) > From: lompik@voila.fr > Cc: 18545@debbugs.gnu.org > > here's a related scrolling involving the lisp function recenter: > > 1. emacs -Q > 2. define those binding: > > > (global-set-key (kbd "C-`") '(lambda () > (interactive) > (with-selected-window (get-buffer-window "*Completions*") > (forward-line 1)))) > > (global-set-key (kbd "C-~") '(lambda () > (interactive) > (with-selected-window (get-buffer-window "*Completions*") > (forward-line -1)))) > > (global-set-key (kbd "C-;") '(lambda () > (interactive) > (with-selected-window (get-buffer-window "*Completions*") > (recenter 5)))) > > 3. do: > > C-x C-f -> in a directory with lots of file. > tab tab -> open completion buffer > C-` -> to until scrolling down the *completion* buffer > > hit "C-;" -> nothing happens. it should recenter. > hit "C-'`" -> it recenter then move one line down I'm not sure this is related to this bug. The problem here was that the display engine was not considering for redisplay the window showing the *Completions* buffer. The patch below fixes that. === modified file 'src/window.c' --- src/window.c 2014-09-11 08:47:34 +0000 +++ src/window.c 2014-09-26 07:28:02 +0000 @@ -5897,6 +5897,8 @@ and redisplay normally--don't erase and w->start_at_line_beg = (bytepos == BEGV_BYTE || FETCH_BYTE (bytepos - 1) == '\n'); + wset_redisplay (w); + set_buffer_internal (obuf); return Qnil; }