From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23075: 24.5; vc-git-command should use coding-system-for-read Date: Mon, 21 Mar 2016 18:16:14 +0200 Message-ID: <83wpov6c35.fsf@gnu.org> References: <56EFD97C.3080805@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1458577049 4362 80.91.229.3 (21 Mar 2016 16:17:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2016 16:17:29 +0000 (UTC) Cc: 23075@debbugs.gnu.org To: Nikolay Kudryavtsev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 17:17:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ai2W5-0000hC-CJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 17:17:17 +0100 Original-Received: from localhost ([::1]:58815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai2W4-0001UR-Ri for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 12:17:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai2Vv-0001MU-Fv for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:17:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai2Vq-0006jS-EL for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:17:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai2Vq-0006jO-Ao for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ai2Vq-0000X6-4s for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2016 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23075 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23075-submit@debbugs.gnu.org id=B23075.14585770082023 (code B ref 23075); Mon, 21 Mar 2016 16:17:02 +0000 Original-Received: (at 23075) by debbugs.gnu.org; 21 Mar 2016 16:16:48 +0000 Original-Received: from localhost ([127.0.0.1]:57154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai2Vc-0000WZ-Iv for submit@debbugs.gnu.org; Mon, 21 Mar 2016 12:16:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai2Va-0000WM-PR for 23075@debbugs.gnu.org; Mon, 21 Mar 2016 12:16:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai2VQ-0006d3-O5 for 23075@debbugs.gnu.org; Mon, 21 Mar 2016 12:16:41 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai2VQ-0006cx-L8; Mon, 21 Mar 2016 12:16:36 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2826 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ai2VP-0004xr-Uz; Mon, 21 Mar 2016 12:16:36 -0400 In-reply-to: <56EFD97C.3080805@gmail.com> (message from Nikolay Kudryavtsev on Mon, 21 Mar 2016 14:22:36 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115242 Archived-At: > From: Nikolay Kudryavtsev > Date: Mon, 21 Mar 2016 14:22:36 +0300 > > If you have files in your repositories, that are in different coding > system from vc-git-commits-coding-system, vc-diff would still show diffs > for them in vc-git-commits-coding-system. > > This is unnecessary, since vc-diff-internal already decides what coding > system to use based on the first file and then sets > coding-system-for-read accordingly. > > The fix is to change vc-git-command to use coding-system-for-read > whenever it's bound. Please show a recipe for reproducing this problem with a recent Git version and preferably with the latest pretest of Emacs 25.1. Please include any files necessary for the reproduction. Before we dive into this tricky issue, I'd like to be sure the problem still exists (since more than a year has passed since your original reports). Also, this is specific to MS-Windows, right? Thanks.