From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env Date: Fri, 17 Jun 2016 17:01:23 +0300 Message-ID: <83wplnc3t8.fsf@gnu.org> References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1466175097 28379 80.91.229.3 (17 Jun 2016 14:51:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jun 2016 14:51:37 +0000 (UTC) Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 17 16:51:24 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDv5L-0003IH-0P for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 16:49:27 +0200 Original-Received: from localhost ([::1]:58093 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDv5K-0004fV-8t for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 10:49:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDuKW-0006IR-9z for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 10:01:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDuKU-00054h-Jm for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 10:01:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDuKU-00054d-H4 for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 10:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bDuKU-000662-8b for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 10:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jun 2016 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23779-submit@debbugs.gnu.org id=B23779.146617204923406 (code B ref 23779); Fri, 17 Jun 2016 14:01:02 +0000 Original-Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 14:00:49 +0000 Original-Received: from localhost ([127.0.0.1]:44380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDuKH-00065S-0V for submit@debbugs.gnu.org; Fri, 17 Jun 2016 10:00:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDuKE-00065C-Vy for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 10:00:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDuK8-0004tz-PI for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 10:00:41 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDuK8-0004tm-Gm; Fri, 17 Jun 2016 10:00:40 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4459 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bDuK4-0000ze-K3; Fri, 17 Jun 2016 10:00:39 -0400 In-reply-to: <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> (message from Dmitry Gutov on Fri, 17 Jun 2016 15:17:38 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119667 Archived-At: > Cc: 23779@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 17 Jun 2016 15:17:38 +0300 > > On 06/17/2016 10:11 AM, Eli Zaretskii wrote: > > > Where does it say that you can use 'cons' or 'push', and only them, to > > the effect of removing the variable from the environment passed to > > child processes? > > That works with other Emacs features, such as auto-mode-alist. There should be code to make it work, it won't work by itself. (auto-mode-alist is different, because it's used entirely in Lisp. By contrast, here we must construct the C-level environment array we pass to child programs so as to remove the variable from it.) > You can also override the values in process-environment using a cons > (which strongly suggests the semantics of "first element wins"). Just > not "remove" them, currently. Looks like this never worked as intended. Does the patch below fix this? diff --git a/src/callproc.c b/src/callproc.c index db602f5..2fb5b1d 100644 --- a/src/callproc.c +++ b/src/callproc.c @@ -1099,7 +1099,7 @@ add_env (char **env, char **new_env, char *string) char *p = *ep, *q = string; while (ok) { - if (*q != *p) + if (*p && *q != *p) break; if (*q == 0) /* The string is a lone variable name; keep it for now, we