From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net
Subject: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env
Date: Fri, 17 Jun 2016 17:01:23 +0300 [thread overview]
Message-ID: <83wplnc3t8.fsf@gnu.org> (raw)
In-Reply-To: <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> (message from Dmitry Gutov on Fri, 17 Jun 2016 15:17:38 +0300)
> Cc: 23779@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 17 Jun 2016 15:17:38 +0300
>
> On 06/17/2016 10:11 AM, Eli Zaretskii wrote:
>
> > Where does it say that you can use 'cons' or 'push', and only them, to
> > the effect of removing the variable from the environment passed to
> > child processes?
>
> That works with other Emacs features, such as auto-mode-alist.
There should be code to make it work, it won't work by itself.
(auto-mode-alist is different, because it's used entirely in Lisp. By
contrast, here we must construct the C-level environment array we pass
to child programs so as to remove the variable from it.)
> You can also override the values in process-environment using a cons
> (which strongly suggests the semantics of "first element wins"). Just
> not "remove" them, currently.
Looks like this never worked as intended. Does the patch below fix
this?
diff --git a/src/callproc.c b/src/callproc.c
index db602f5..2fb5b1d 100644
--- a/src/callproc.c
+++ b/src/callproc.c
@@ -1099,7 +1099,7 @@ add_env (char **env, char **new_env, char *string)
char *p = *ep, *q = string;
while (ok)
{
- if (*q != *p)
+ if (*p && *q != *p)
break;
if (*q == 0)
/* The string is a lone variable name; keep it for now, we
next prev parent reply other threads:[~2016-06-17 14:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 3:33 bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env Noam Postavsky
2016-06-17 7:11 ` Eli Zaretskii
2016-06-17 12:17 ` Dmitry Gutov
2016-06-17 14:01 ` Eli Zaretskii [this message]
2016-06-17 14:12 ` Dmitry Gutov
2016-06-17 14:19 ` Eli Zaretskii
2016-06-17 14:47 ` Dmitry Gutov
2016-06-17 16:52 ` Andreas Schwab
2016-06-17 16:55 ` Dmitry Gutov
2016-06-17 17:06 ` Eli Zaretskii
2016-06-17 19:01 ` Dmitry Gutov
2016-06-17 20:10 ` Eli Zaretskii
2016-06-17 21:26 ` Dmitry Gutov
2016-06-18 7:51 ` Eli Zaretskii
2016-06-18 1:36 ` Noam Postavsky
2016-06-18 1:44 ` Dmitry Gutov
2016-06-19 2:27 ` Paul Eggert
2016-06-19 15:01 ` Eli Zaretskii
2016-06-19 22:53 ` Paul Eggert
2016-06-20 14:21 ` Eli Zaretskii
2016-06-21 13:53 ` Dmitry Gutov
2016-06-21 15:21 ` Eli Zaretskii
2016-06-21 15:24 ` Dmitry Gutov
2016-06-21 16:12 ` Eli Zaretskii
2016-06-21 23:05 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wplnc3t8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23779@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).