From: Eli Zaretskii <eliz@gnu.org>
To: "Clément Pit--Claudel" <clement.pitclaudel@live.com>
Cc: 25592@debbugs.gnu.org
Subject: bug#25592: Feature request: sorting overlays
Date: Sun, 05 Feb 2017 20:28:53 +0200 [thread overview]
Message-ID: <83wpd47aqi.fsf@gnu.org> (raw)
In-Reply-To: <21abc5a1-0777-cd33-ff26-2cd0853e9161@live.com> (message from Clément Pit--Claudel on Sun, 5 Feb 2017 11:21:04 -0500)
> Cc: 25592@debbugs.gnu.org
> From: Clément Pit--Claudel <clement.pitclaudel@live.com>
> Date: Sun, 5 Feb 2017 11:21:04 -0500
>
> > Why would you need to keep track of overlays, if you always process
> > each one just once?
>
> To avoid applying the same overlay twice. But I think I understand your suggestion better now, and you meant that I would apply each overlay's properties not to the entire overlay's range (overlay-start .. overlay-end), but instead just to the current range (as determined by next-overlay-change). Correct?
Yes, of course. That's how the display engine handles overlays.
> > But the "simpler" solution has a problem, whereby the order of the
> > overlays might depend on buffer position for which you evaluate the
> > order, because overlays could begin at the same position, but end at
> > different ones, or vice versa. IOW, the overlaps between portions
> > of the buffer text "covered" by different overlays could be partial.
> > How do you handle this situation in your algorithm? The correct
> > solution would require having different values of the corresponding
> > text property for different locations, according to the
> > highest-priority overlay at each location. Am I missing something?
>
> I think I'm probably the one missing something :) I'm not sure I understand the problem. Here's my current algorithm:
> [...]
> (defun esh--commit-overlays (buf)
> "Copy overlays of BUF into current buffer's text properties."
> (let ((pt-min-diff (- (with-current-buffer buf (point-min)) (point-min))))
> (dolist (ov (esh--buffer-overlays buf))
> (let* ((start (max (point-min) (- (overlay-start ov) pt-min-diff)))
> (end (min (point-max) (- (overlay-end ov) pt-min-diff)))
> (ov-props (overlay-properties ov))
> (cat-props (let ((symbol (plist-get ov-props 'category)))
> (and symbol (symbol-plist symbol))))
> (face (let ((mem (plist-member ov-props 'face)))
> (if mem (cadr mem) (plist-get cat-props 'face))))
> (props (esh--filter-plist (append cat-props ov-props)
> (cons 'face esh--overlay-specific-props))))
> (when face
> (font-lock-prepend-text-property start end 'face face))
> (add-text-properties start end props)))))
What will happen if you have 2 overlays like this:
+------------- OV2 -------+
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
+------- OV1 ---------+
and OV2 has a higher priority than OV1?
> >>>>> How did you implement in Lisp the "last resort" of
> >>>>> comparison, which compares addresses of the C structs?
> >>>>
> >>>> I didn't :)
> >>>
> >>> So it isn't really a solution ;-)
> >>
> >> It's not a full reimplementation, but it's enough of a solution for
> >> me :) The docs say “If SORTED is non-‘nil’, the list is in
> >> decreasing order of priority”, and that's what my implementation
> >> does.
> >
> > Then there will be use cases where your solution will give a wrong
> > value to the text property that replaces the overlays.
>
> Snap. Do you have a concrete example? I imagine this would happen if two overlays are added to the same range of text, with no explicit priority?
Or with explicitly equal priority.
next prev parent reply other threads:[~2017-02-05 18:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 20:32 bug#25592: Feature request: sorting overlays Clément Pit--Claudel
2017-02-01 13:01 ` Eli Zaretskii
2017-02-02 19:41 ` Clément Pit--Claudel
2017-02-02 20:43 ` Eli Zaretskii
2017-02-03 15:19 ` Clément Pit--Claudel
2017-02-03 21:17 ` Eli Zaretskii
2017-02-03 21:51 ` Clément Pit--Claudel
2017-02-04 8:13 ` Eli Zaretskii
2017-02-05 16:21 ` Clément Pit--Claudel
2017-02-05 18:28 ` Eli Zaretskii [this message]
2017-02-05 19:10 ` Clément Pit--Claudel
2017-02-05 19:43 ` Eli Zaretskii
2017-02-05 19:51 ` Clément Pit--Claudel
2017-02-07 17:13 ` Eli Zaretskii
2017-02-07 19:17 ` Clément Pit--Claudel
2017-02-07 19:56 ` Eli Zaretskii
2017-02-07 20:07 ` Clément Pit--Claudel
2017-02-08 17:22 ` Eli Zaretskii
2017-02-09 19:50 ` Clément Pit--Claudel
2017-02-03 23:28 ` Johan Bockgård
2017-02-04 8:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wpd47aqi.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25592@debbugs.gnu.org \
--cc=clement.pitclaudel@live.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).