From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: tzz@lifelogs.com, 24150@debbugs.gnu.org, sdl.web@gmail.com,
clement.pit@gmail.com
Subject: bug#24150: 26.0.50; New command: dired-create-empty-file
Date: Wed, 05 Jul 2017 21:28:07 +0300 [thread overview]
Message-ID: <83wp7mn3go.fsf@gnu.org> (raw)
In-Reply-To: <87mv8m3yya.fsf@calancha-pc> (message from Tino Calancha on Mon, 03 Jul 2017 13:51:25 +0900)
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Mon, 03 Jul 2017 13:51:25 +0900
> Cc: Ted Zlatanov <tzz@lifelogs.com>, tino.calancha@gmail.com,
> Clément Pit--Claudel <clement.pit@gmail.com>,
> Leo Liu <sdl.web@gmail.com>
>
> If there are no objections, i would like to apply the following patch
> in a few days:
If no one else chimes in until this weekend, please push, after taking
care of the few minor issues below:
> (dired-create-empty-file): New command.
I'd prefer a non-Dired function, and I think files.el is a better
place for such a general function.
> +@kindex _ @r{(Dired)}
> +@findex dired-create-empty-file
> + Likewise, @kbd{_} (@code{dired-create-empty-file}) reads a
> +file name, and creates an empty file with that name. It signals
> +an error if the file already exists.
Please add here a @cindex entry about "create empty file". Also, if
the command is going to be not Dired-specific, it should be described
in another section of the manual.
> ** Dired
> -You can now use '`?`' in 'dired-do-shell-command'; as ' ? ', it gets replaced
> -by the current file name.
> +
> +*** New command 'dired-create-empty-file' (similar to
> +'dired-create-directory') creates a new empty file; bound to '_'.
Since this is documented in the manual, it should be marked with
"+++". (Renaming the command affects this part as well.)
> +*** You can now use '`?`' in 'dired-do-shell-command'; as ' ? ',
> +it gets replaced by the current file name.
This looks unrelated.
> + (when (file-exists-p expanded)
> + (error "Cannot create file %s: file exists" expanded))
If the file is actually a directory, I think the error message should
say so.
Finally, how about some simple tests for this new command?
Thanks.
next prev parent reply other threads:[~2017-07-05 18:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 13:25 bug#24150: 25.1.50; New command: dired-create-empty-file Tino Calancha
2016-08-04 13:54 ` Clément Pit--Claudel
2016-08-04 16:29 ` Leo Liu
2016-08-04 17:13 ` Ted Zlatanov
2016-08-04 17:29 ` Drew Adams
2016-08-05 6:03 ` Tino Calancha
2016-08-05 14:48 ` Drew Adams
2016-08-06 12:38 ` Tino Calancha
2016-08-05 6:07 ` Tino Calancha
2017-05-03 8:23 ` Tino Calancha
2017-07-03 4:51 ` bug#24150: 26.0.50; " Tino Calancha
2017-07-03 14:24 ` Eli Zaretskii
2017-07-03 15:04 ` Tino Calancha
2017-07-03 16:33 ` Eli Zaretskii
2017-07-03 20:18 ` Thien-Thi Nguyen
2017-07-07 13:13 ` Ted Zlatanov
2017-07-07 13:17 ` Drew Adams
2017-07-07 13:31 ` Ted Zlatanov
2017-07-03 15:12 ` Drew Adams
2017-07-05 18:28 ` Eli Zaretskii [this message]
2017-07-05 19:34 ` Drew Adams
2017-07-07 5:36 ` Tino Calancha
2017-07-07 11:11 ` Drew Adams
2018-07-10 7:01 ` Tino Calancha
2018-07-10 7:42 ` Phil Sainty
2018-07-17 7:39 ` Tino Calancha
2018-07-20 9:03 ` Eli Zaretskii
2018-07-23 3:57 ` Tino Calancha
2018-07-27 8:39 ` Eli Zaretskii
2018-07-31 4:47 ` Tino Calancha
2018-07-31 16:20 ` Eli Zaretskii
2018-08-01 5:16 ` Tino Calancha
2018-08-01 6:24 ` Eli Zaretskii
2018-08-01 7:13 ` Tino Calancha
2018-08-01 8:56 ` Eli Zaretskii
2018-08-01 9:31 ` Tino Calancha
2018-08-01 11:45 ` Eli Zaretskii
2018-08-02 4:34 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wp7mn3go.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24150@debbugs.gnu.org \
--cc=clement.pit@gmail.com \
--cc=sdl.web@gmail.com \
--cc=tino.calancha@gmail.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).