From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27584: 26.0.50; alist-get: Add optional arg TESTFN Date: Sat, 08 Jul 2017 09:30:00 +0300 Message-ID: <83wp7jl9uf.fsf@gnu.org> References: <87tw2rva7v.fsf@calancha-pc> <87mv8j6y1z.fsf@petton.fr> <87y3s2m76v.fsf@calancha-pc> <8760f562bo.fsf@petton.fr> <877ezk3g4p.fsf@calancha-pc> <874luovf7a.fsf@petton.fr> <87shi8tzkr.fsf@petton.fr> <8737a858so.fsf@petton.fr> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1499495478 32159 195.159.176.226 (8 Jul 2017 06:31:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Jul 2017 06:31:18 +0000 (UTC) Cc: 27584@debbugs.gnu.org, monnier@IRO.UMontreal.CA, tino.calancha@gmail.com To: Nicolas Petton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 08 08:31:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTjGm-0007kw-Gt for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Jul 2017 08:31:08 +0200 Original-Received: from localhost ([::1]:60032 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTjGo-0000o7-OF for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Jul 2017 02:31:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTjGj-0000o1-GW for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 02:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTjGg-000190-7E for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 02:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54558) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dTjGg-00018w-3K for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 02:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dTjGf-00025j-Qy for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 02:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jul 2017 06:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27584 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27584-submit@debbugs.gnu.org id=B27584.14994954488020 (code B ref 27584); Sat, 08 Jul 2017 06:31:01 +0000 Original-Received: (at 27584) by debbugs.gnu.org; 8 Jul 2017 06:30:48 +0000 Original-Received: from localhost ([127.0.0.1]:57235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTjGR-00025I-Re for submit@debbugs.gnu.org; Sat, 08 Jul 2017 02:30:47 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTjGR-000256-0g for 27584@debbugs.gnu.org; Sat, 08 Jul 2017 02:30:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTjGI-0000zG-GA for 27584@debbugs.gnu.org; Sat, 08 Jul 2017 02:30:41 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTjFr-0000pJ-BM; Sat, 08 Jul 2017 02:30:11 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1142 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dTjFq-0002vn-Ds; Sat, 08 Jul 2017 02:30:10 -0400 In-reply-to: <8737a858so.fsf@petton.fr> (message from Nicolas Petton on Fri, 07 Jul 2017 21:47:03 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134320 Archived-At: > From: Nicolas Petton > Date: Fri, 07 Jul 2017 21:47:03 +0200 > Cc: 27584@debbugs.gnu.org, Tino Calancha > > + if (NILP (testfn)) > + { > + if (CONSP (car) > + && (EQ (XCAR (car), key) || !NILP (Fequal (XCAR (car), key)))) > + return car; > + } > + else if (CONSP (car) && (!NILP (call2 (testfn, (XCAR (car)), key)))) > + { > + return car; > + } No need for braces when there's only one line to enclose. Also, no need for parentheses around "!NILP (...)". Bonus points for simplifying the code by determining TESTFN up front, then having only one of the above two clauses. Thanks.