unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: npostavs@users.sourceforge.net
Cc: 2967@debbugs.gnu.org, monnier@iro.umontreal.ca, acm@muc.de
Subject: bug#2967: smart quotes in .emacs
Date: Sat, 22 Jul 2017 12:20:59 +0300	[thread overview]
Message-ID: <83wp70969w.fsf@gnu.org> (raw)
In-Reply-To: <87shhvc2fw.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net)

> From: npostavs@users.sourceforge.net
> Cc: 2967@debbugs.gnu.org,  rgm@gnu.org,  monnier@iro.umontreal.ca,  acm@muc.de
> Date: Sun, 16 Jul 2017 20:49:39 -0400
> 
> > Please include the character itself in the error message text.
> >
> > Also, are we sure these two are the only ones we want to catch in this
> > manner?
> 
> I added some more likely looking ones from
> https://en.wikipedia.org/wiki/Quotation_mark_glyphs.
> 
> > Finally, if this is accepted, let's have a test for this, and maybe
> > also some documentation, at least in NEWS.
> 
> 
> >From 438030f42698f347e38a9dea1561eedadd7e2edc Mon Sep 17 00:00:00 2001
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Wed, 7 Jun 2017 19:59:09 -0400
> Subject: [PATCH v2] Signal error for symbol names with strange quotes
>  (Bug#2967)
> 
> * src/lread.c (read1): Signal an error when a symbol starts with a
> non-escaped quote-like character.
> * test/src/lread-tests.el (lread-tests--funny-quote-symbols): New
> test.
> * etc/NEWS: Announce change.

Thanks, this LGTM.  Please push.





  reply	other threads:[~2017-07-22  9:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-12 12:53 bug#2967: smart quotes in .emacs Kit O'Connell
2009-04-13 12:23 ` Stefan Monnier
2012-08-10 19:59   ` Glenn Morris
2017-06-07  3:46     ` npostavs
2017-06-07  5:09       ` Eli Zaretskii
2017-07-17  0:49         ` npostavs
2017-07-22  9:20           ` Eli Zaretskii [this message]
2017-07-22 14:41             ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wp70969w.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=2967@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=monnier@iro.umontreal.ca \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).