From: Eli Zaretskii <eliz@gnu.org>
To: Ari Roponen <ari.roponen@gmail.com>
Cc: 31288@debbugs.gnu.org
Subject: bug#31288: 27.0.50; [PATCH] Make cairo build somewhat usable
Date: Fri, 27 Apr 2018 17:15:22 +0300 [thread overview]
Message-ID: <83wowsu45h.fsf@gnu.org> (raw)
In-Reply-To: <87lgd8kcrv.fsf@gmail.com> (message from Ari Roponen on Fri, 27 Apr 2018 16:19:16 +0300)
> From: Ari Roponen <ari.roponen@gmail.com>
> Date: Fri, 27 Apr 2018 16:19:16 +0300
>
> Attached are two patches to make --with-cairo builds more usable.
>
> First patch tries to fix screen corruption, and the second patch allows
> cairo builds to display images.
Thank you for working on this.
Please allow me a couple of minor comments on the changes:
> @@ -1236,7 +1231,8 @@ x_update_end (struct frame *f)
> {
> cairo_t *cr = 0;
> block_input();
> -#if defined (USE_GTK) && defined (HAVE_GTK3)
> + /* FIXME */
> +#if 0 && defined (USE_GTK) && defined (HAVE_GTK3)
> if (FRAME_GTK_WIDGET (f))
> {
> GdkWindow *w = gtk_widget_get_window (FRAME_GTK_WIDGET (f));
This hunk doesn't look right. If the code in question causes some
trouble to a Cairo build, please ifdef it out only when USE_CAIRO is
defined, not unconditionally. And if that still needs a FIXME
comment, please add some description of what needs to be fixed and
why.
> + cairo_surface_destroy (s);
> + } else {
> + SET_FRAME_GARBAGED (f);
Please use GNU style of braces.
Thanks again.
next prev parent reply other threads:[~2018-04-27 14:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 13:19 bug#31288: 27.0.50; [PATCH] Make cairo build somewhat usable Ari Roponen
2018-04-27 14:15 ` Eli Zaretskii [this message]
2018-04-27 14:35 ` Ari Roponen
2018-04-27 14:55 ` Eli Zaretskii
2018-04-27 15:51 ` Ari Roponen
2018-04-28 7:33 ` bug#31288: [PATCH v2] Make cairo build usable Ari Roponen
2018-05-05 9:35 ` Eli Zaretskii
2018-05-06 12:36 ` Ari Roponen
2018-05-06 18:29 ` Eli Zaretskii
[not found] ` <wltvfq1l5v.wl-mituharu@math.s.chiba-u.ac.jp>
2019-03-26 6:13 ` Ari Roponen
2019-03-26 7:45 ` YAMAMOTO Mitsuharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wowsu45h.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=31288@debbugs.gnu.org \
--cc=ari.roponen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).