From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) Date: Tue, 04 Sep 2018 20:11:49 +0300 Message-ID: <83wos1xk4q.fsf@gnu.org> References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <86wos25gvy.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1536081135 14893 195.159.176.226 (4 Sep 2018 17:12:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Sep 2018 17:12:15 +0000 (UTC) Cc: 25967@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 04 19:12:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxEs7-0003ly-0A for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Sep 2018 19:12:11 +0200 Original-Received: from localhost ([::1]:51905 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxEuC-0000fT-RI for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Sep 2018 13:14:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxEt8-00080B-42 for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 13:13:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxEsw-0004yH-Kg for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 13:13:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40945) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxEsw-0004y0-EB for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 13:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fxEsw-0005yB-7m for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 13:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Sep 2018 17:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25967 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25967-submit@debbugs.gnu.org id=B25967.153608112822877 (code B ref 25967); Tue, 04 Sep 2018 17:13:02 +0000 Original-Received: (at 25967) by debbugs.gnu.org; 4 Sep 2018 17:12:08 +0000 Original-Received: from localhost ([127.0.0.1]:45963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxEs3-0005wu-MX for submit@debbugs.gnu.org; Tue, 04 Sep 2018 13:12:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxEs1-0005wP-Jc for 25967@debbugs.gnu.org; Tue, 04 Sep 2018 13:12:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxErt-0003pQ-73 for 25967@debbugs.gnu.org; Tue, 04 Sep 2018 13:12:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxErt-0003oZ-2o; Tue, 04 Sep 2018 13:11:57 -0400 Original-Received: from [176.228.60.248] (port=2904 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fxErs-000351-H3; Tue, 04 Sep 2018 13:11:57 -0400 In-reply-to: <86wos25gvy.fsf@gmail.com> (message from Andy Moreton on Mon, 03 Sep 2018 23:57:05 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150015 Archived-At: > From: Andy Moreton > Date: Mon, 03 Sep 2018 23:57:05 +0100 > > As a followup, here is a patch to add ImageMagick support for Windows. > The patch was initially developed for Imagemagick 6, but I've updated it > to support ImageMagick 7. > > I've given this some light testing on a 64bit mingw64 (MSYS2) and 64bit > cygwin builds, both of which use Imagemagick 7. > > Please test, and report if it breaks anything on other platforms. Thanks. A couple of minor comments: This needs a NEWS entry. > + '(imagemagick "libMagickWand-7.Q16HDRI-6.dll"))) Is this DLL name fixed for all the supported versions? It sounds like it's only for Imagemagick v7, and so the DLL for version 6 will be named differently. Also, AFAIU, there are binary incompatibilities between v6 and v7, so an Emacs compiled with one of them should not attempt to load DLLs from another, is that right? For these two reasons, I think we should have a Lisp variable that provides the version of Imagemagick with which Emacs was built, and we need the dispatch in w32-win.el for loading the correct DLLs based on that variable, like we do with libgif etc.