From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33195: 27.0.50; user-login-name has no group-login-name Date: Sat, 10 Nov 2018 21:15:34 +0200 Message-ID: <83wopkagmh.fsf@gnu.org> References: <87d0rsegbi.fsf@gmail.com> <837ehzlo3a.fsf@gnu.org> <871s87e1gi.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1541877310 22551 195.159.176.226 (10 Nov 2018 19:15:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Nov 2018 19:15:10 +0000 (UTC) Cc: 33195@debbugs.gnu.org, jtamagnan@gmail.com To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 10 20:15:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLYio-0005kO-9d for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Nov 2018 20:15:06 +0100 Original-Received: from localhost ([::1]:39675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLYku-00046J-PF for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Nov 2018 14:17:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLYkm-000468-QX for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 14:17:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLYkg-0000Rf-DV for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 14:17:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40722) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gLYkg-0000RY-86 for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 14:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gLYkg-00010h-2b for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 14:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Nov 2018 19:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33195 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33195-submit@debbugs.gnu.org id=B33195.15418773753826 (code B ref 33195); Sat, 10 Nov 2018 19:17:02 +0000 Original-Received: (at 33195) by debbugs.gnu.org; 10 Nov 2018 19:16:15 +0000 Original-Received: from localhost ([127.0.0.1]:44980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLYju-0000zd-7k for submit@debbugs.gnu.org; Sat, 10 Nov 2018 14:16:15 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLYjs-0000zQ-K2 for 33195@debbugs.gnu.org; Sat, 10 Nov 2018 14:16:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLYjh-0007oc-Nj for 33195@debbugs.gnu.org; Sat, 10 Nov 2018 14:16:07 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLYjh-0007oS-AW; Sat, 10 Nov 2018 14:16:01 -0500 Original-Received: from [176.228.60.248] (port=2801 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gLYjc-0002rx-5d; Sat, 10 Nov 2018 14:16:01 -0500 In-reply-to: (message from Glenn Morris on Sat, 10 Nov 2018 13:36:47 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152264 Archived-At: > From: Glenn Morris > Cc: Eli Zaretskii , 33195@debbugs.gnu.org > Date: Sat, 10 Nov 2018 13:36:47 -0500 > > Jules Tamagnan wrote: > > > I've tried my hand at writing a test for this but am dubious it will > > pass on all machines, I believe it should work on gnu/linux > [...] > > +(ert-deftest group-name () > > + (let ((list `((0 . "root") > > + (1000 . ,(user-login-name 1000)) > > + (1212345 . nil)))) > > + (dolist (test list) > > + (should (equal (group-name (car test)) (cdr test)))))) > > This assumes that user 1000's primary group is the same as their login name. > This is not at all guaranteed, so I will remove it. > Eg it fails for me on rhel 7.5, and also on hydra.nixos.org, ref > https://hydra.nixos.org/eval/1488740 > > I guess that UID 0 is always the root group, but I wouldn't swear to it. > The 1212345 thing relies on UID 1212345 not existing. > It seems to me that this is fragile too. > So all in all, I'm not sure this test is very useful. Maybe all platforms should use the same code as MS-Windows for this test, then.