From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33618: 27.0.50; ada-mode breaks M-x grep Date: Wed, 05 Dec 2018 08:41:46 +0200 Message-ID: <83wooo8ogl.fsf@gnu.org> References: NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1543992070 6157 195.159.176.226 (5 Dec 2018 06:41:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Dec 2018 06:41:10 +0000 (UTC) Cc: stephen_leake@member.fsf.org, 33618@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 05 07:41:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUQro-0001QP-2Z for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Dec 2018 07:41:04 +0100 Original-Received: from localhost ([::1]:60313 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUQtu-0004lB-G0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Dec 2018 01:43:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUQtn-0004kr-08 for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 01:43:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUQti-0000Am-7f for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 01:43:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57001) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gUQth-0000AW-W4 for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 01:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gUQth-0003Np-ST for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2018 01:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Dec 2018 06:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33618 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33618-submit@debbugs.gnu.org id=B33618.154399213212944 (code B ref 33618); Wed, 05 Dec 2018 06:43:01 +0000 Original-Received: (at 33618) by debbugs.gnu.org; 5 Dec 2018 06:42:12 +0000 Original-Received: from localhost ([127.0.0.1]:33026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUQst-0003Mi-Pg for submit@debbugs.gnu.org; Wed, 05 Dec 2018 01:42:12 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUQss-0003MW-E2 for 33618@debbugs.gnu.org; Wed, 05 Dec 2018 01:42:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUQsl-0007rT-7B for 33618@debbugs.gnu.org; Wed, 05 Dec 2018 01:42:05 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUQsa-0007ki-VR; Wed, 05 Dec 2018 01:41:53 -0500 Original-Received: from [176.228.60.248] (port=3153 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gUQsZ-00064T-7z; Wed, 05 Dec 2018 01:41:52 -0500 In-reply-to: (message from Stefan Monnier on Tue, 04 Dec 2018 19:02:35 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153094 Archived-At: > From: Stefan Monnier > Date: Tue, 04 Dec 2018 19:02:35 -0500 > Cc: Stephen Leake > > > Opening a file in ada-mode using the new ada-mode from GNU ELPA globally > > sets compilation-search-path (for me, it got set to `("~/tmp")` > > probably because the Ada file was in ~/tmp), which in > > turn breaks M-x grep in the sense that clicking on a match doesn't jump > > to the file but prompts you to find the file (unless you happened to > > grep from one of the directories mentioned in the > > compilation-search-path, of course). > > I use the patch below currently to work around this problem. > Should I install it into `master` (with a few more comments and > probably etc/NEWS or even manual updates)? If the problem is in ada-mode in ELPA, it should be fixed there, IMO. Why do we need to change our code to cater to problems in packages, even if those packages are on ELPA? It sounds wrong to me, FWIW.